Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are action_type "impression" and action_type "view" semantically the same? #32

Closed
wrigleyDan opened this issue Nov 21, 2024 · 2 comments

Comments

@wrigleyDan
Copy link

In the list of possible action_type values there are impression and view listed.

How do they differ? If they don't they should be merged, i.e. only one should be kept.

@epugh
Copy link
Member

epugh commented Jan 22, 2025

I think an impression is whne you see something, so you get 10 results and see 4, then 4 impressions. A view is "I viewed a help page".. It refers to an overall thing?

Or, is "impression" the term of art we use to refer to anything? Or, is the "4 impressions" not actually the right term?

@wrigleyDan
Copy link
Author

I think 4 impressions is the right terminology and I can see the distinction between view and impression the way you describe it.

We should probably have more documentation around what the different action_type elements actually mean.

Closing this one as the underlying question of this issue is answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants