engine: Add button to remove all direct user permissions #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small UI demo
|
sandrobonazzola
requested review from
dupondje and
a team
and removed request for
sgratch
barpavel
reviewed
Oct 10, 2024
...t-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
Outdated
Show resolved
Hide resolved
...nweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java
Outdated
Show resolved
Hide resolved
...nweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java
Outdated
Show resolved
Hide resolved
...nweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java
Show resolved
Hide resolved
...ommon/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ru.properties
Outdated
Show resolved
Hide resolved
This button useful for large instances, when we have many roles for each user. Some times we want to totally clean roles for user, and this can be hard to look at all roles and search each direct one. Signed-off-by: Stanislav Melnichuk <[email protected]>
Signed-off-by: Stanislav Melnichuk <[email protected]>
0ffer
force-pushed
the
remove-all-direct-roles-with-single-button
branch
from
82ac13b to
3a59c79
Compare
barpavel
approved these changes
Oct 14, 2024
barpavel
reviewed
Oct 14, 2024
...ommon/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ru.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Melnichuk <[email protected]>
barpavel
approved these changes
Oct 14, 2024
dupondje
approved these changes
Oct 16, 2024
Yep, I can squash it manually. |
|
GitHub supports squashing, I can squash while merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This button useful for large instances, when we have many roles for each user. Some times we want to totally clean roles for user, and this can be hard to look at all roles and search each direct one.
All logic is on UI side, I just modify selected items on-the-fly.
Changes introduced with this PR
Are you the owner of the code you are sending in, or do you have permission of the owner?
y