Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: sentence clarification #257

Open
Sakurann opened this issue Oct 7, 2024 · 1 comment · May be fixed by #296
Open

ed: sentence clarification #257

Sakurann opened this issue Oct 7, 2024 · 1 comment · May be fixed by #296
Assignees
@awoie

Comments

@Sakurann
Copy link
Collaborator

Sakurann commented Oct 7, 2024

I don't understand this sentence that points to the claims that are REQUIRED: If present, the following registered JWT claims MUST be included in the SD-JWT and MUST NOT be included in the Disclosures, i.e. cannot be selectively disclosed: the sentence also uses two normative statements in one. Could it be clarified/simplified as something like: The following registered JWT claims MUST NOT be included in the Disclosures, i.e. cannot be selectively disclosed:
Thanks.
@danielfett
Copy link
Member

Discussed on the editors' call. Yes, the first part of the sentence is not great. What you propose makes sense, we may want to add that the context is "during issuance".

@danielfett danielfett added the Ready-for-PR Needs PR (typically after resolved discussion) label Oct 8, 2024
@bc-pi bc-pi mentioned this issue Oct 8, 2024
Open
@awoie awoie self-assigned this Nov 26, 2024
@awoie awoie linked a pull request Jan 13, 2025 that will close this issue
Open
@awoie awoie added HAS PR and removed Ready-for-PR Needs PR (typically after resolved discussion) HAS PR labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awoie awoie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ed: improved clarity on registered claims paragraph oauth-wg/oauth-sd-jwt-vc
3 participants
@danielfett @awoie @Sakurann