From a1289fdef404b08a7acbbf0d6d0f93da4c9fc087 Mon Sep 17 00:00:00 2001 From: Ryan Foster Date: Fri, 12 Apr 2024 18:55:07 -0400 Subject: [PATCH] cmake: Replace find_qt with find_package We currently no longer need this functionality. --- .cmake-format.json | 9 ------ CMakeLists.txt | 4 +-- cmake/common/helpers_common.cmake | 48 ------------------------------- 3 files changed, 2 insertions(+), 59 deletions(-) diff --git a/.cmake-format.json b/.cmake-format.json index b70e8c57..31bd6074 100644 --- a/.cmake-format.json +++ b/.cmake-format.json @@ -6,15 +6,6 @@ "autosort": true }, "additional_commands": { - "find_qt": { - "flags": [], - "kwargs": { - "COMPONENTS": "+", - "COMPONENTS_WIN": "+", - "COMPONENTS_MACOS": "+", - "COMPONENTS_LINUX": "+" - } - }, "set_target_properties_obs": { "pargs": 1, "flags": [], diff --git a/CMakeLists.txt b/CMakeLists.txt index b4fde9c5..2872a9b5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -22,8 +22,8 @@ if(ENABLE_FRONTEND_API) endif() if(ENABLE_QT) - find_qt(COMPONENTS Widgets Core) - target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE Qt::Core Qt::Widgets) + find_package(Qt6 COMPONENTS Widgets Core) + target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE Qt6::Core Qt6::Widgets) target_compile_options( ${CMAKE_PROJECT_NAME} PRIVATE $<$:-Wno-quoted-include-in-framework-header -Wno-comma>) diff --git a/cmake/common/helpers_common.cmake b/cmake/common/helpers_common.cmake index ee3c00f8..cdae2b1e 100644 --- a/cmake/common/helpers_common.cmake +++ b/cmake/common/helpers_common.cmake @@ -6,54 +6,6 @@ include_guard(GLOBAL) -# find_qt: Macro to find best possible Qt version for use with the project: -macro(find_qt) - set(multiValueArgs COMPONENTS COMPONENTS_WIN COMPONENTS_MAC COMPONENTS_LINUX) - cmake_parse_arguments(find_qt "" "${oneValueArgs}" "${multiValueArgs}" ${ARGN}) - - # Do not use versionless targets in the first step to avoid Qt::Core being clobbered by later opportunistic - # find_package runs - set(QT_NO_CREATE_VERSIONLESS_TARGETS TRUE) - - message(DEBUG "Attempting to find Qt 6") - find_package( - Qt6 - COMPONENTS Core - REQUIRED) - - # Enable versionless targets for the remaining Qt components - set(QT_NO_CREATE_VERSIONLESS_TARGETS FALSE) - - set(qt_components ${find_qt_COMPONENTS}) - if(OS_WINDOWS) - list(APPEND qt_components ${find_qt_COMPONENTS_WIN}) - elseif(OS_MACOS) - list(APPEND qt_components ${find_qt_COMPONENTS_MAC}) - else() - list(APPEND qt_components ${find_qt_COMPONENTS_LINUX}) - endif() - message(DEBUG "Trying to find Qt components ${qt_components}...") - - find_package(Qt6 REQUIRED ${qt_components}) - - list(APPEND qt_components Core) - - if("Gui" IN_LIST find_qt_COMPONENTS_LINUX) - list(APPEND qt_components "GuiPrivate") - endif() - - # Check for versionless targets of each requested component and create if necessary - foreach(component IN LISTS qt_components) - message(DEBUG "Checking for target Qt::${component}") - if(NOT TARGET Qt::${component} AND TARGET Qt6::${component}) - add_library(Qt::${component} INTERFACE IMPORTED) - set_target_properties(Qt::${component} PROPERTIES INTERFACE_LINK_LIBRARIES Qt6::${component}) - endif() - set_property(TARGET Qt::${component} PROPERTY INTERFACE_COMPILE_FEATURES "") - endforeach() - -endmacro() - # check_uuid: Helper function to check for valid UUID function(check_uuid uuid_string return_value) set(valid_uuid TRUE)