Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd syntax for main- etc #20

Open
mor1 opened this issue Aug 11, 2013 · 3 comments
Open

odd syntax for main- etc #20

mor1 opened this issue Aug 11, 2013 · 3 comments

Comments

@mor1
Copy link

mor1 commented Aug 11, 2013

the syntax main-noip etc seems very odd to me; the following seems more natural (and more orthogonal across :

  • main: xxx should define the entry point alone (ie., be orthogonal to network config)
  • networking should be specified by the presence of either ip-use-dhcp: true or the presence of all three of ip-static-{address,netmask,gateway}: x.x.x.x

(i guess you could default ip-netmask and ip-gateway to a /24 and x.x.x.1 if you wanted.)

make sense? comments?

@avsm
Copy link
Member

avsm commented Aug 11, 2013

I agree with your syntax.

On 11 Aug 2013, at 23:23, Richard Mortier [email protected] wrote:

the syntax main-noip etc seems very odd to me; the following seems more natural (and more orthogonal across :

main: xxx should define the entry point alone (ie., be orthogonal to network config)
networking should be specified by the presence of either ip-use-dhcp: true or the presence of all three of ip-static-{address,netmask,gateway}: x.x.x.x
(i guess you could default ip-netmask and ip-gateway to a /24 and x.x.x.1 if you wanted.)

make sense? comments?


Reply to this email directly or view it on GitHub.

@samoht
Copy link

samoht commented Aug 12, 2013

I guess I was in a rush when I've added that main-noip target (and didn't have enough examples to find the good design abstraction).

So yes, agreed as well with that design change.

@vbmithr
Copy link

vbmithr commented Aug 12, 2013

On 12/08/2013 09:29, Thomas Gazagnaire wrote:

I guess I was in a rush when I've added that |main-noip| target (and
didn't have enough examples to find the good design abstraction).

So yes, agreed as well with that design change.

I added the main-nopip target, as a quick hack. I'm going to implement
the suggested change as everybody seem to agree :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants