Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocaml5-issue] Gc.counters unsafe root registration #474

Closed
jmid opened this issue Sep 3, 2024 · 1 comment
Closed

[ocaml5-issue] Gc.counters unsafe root registration #474

jmid opened this issue Sep 3, 2024 · 1 comment
Labels
ocaml5-issue A potential issue in the OCaml5 compiler/runtime

Comments

@jmid
Copy link
Collaborator

jmid commented Sep 3, 2024

The Gc test in #469 triggered an issue with Gc.counters, which has recently been fixed on trunk: ocaml/ocaml#13370.
As a memory unsafety issue, this may result in segfaults, BUS error, or abort with Fatal error: allocation failure during minor GC on 5.2.0 or earlier versions.

For example, this 5.2 bytecode workflow yielded
https://github.com/ocaml-multicore/multicoretests/actions/runs/10612162062/job/29413248806

random seed: 160569551
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s STM Gc test sequential
[ ]    0    0    0    0 / 1000     0.0s STM Gc test sequential (generating)
[✓] 1000    0    0 1000 / 1000    48.0s STM Gc test sequential

[ ]    0    0    0    0 / 1000     0.0s STM Gc test parallel
Fatal error: allocation failure during minor GC
File "src/gc/dune", line 4, characters 7-16:
4 |  (name stm_tests)
           ^^^^^^^^^
(cd _build/default/src/gc && ./stm_tests.exe --verbose)
Command got signal ABRT.
[ ]  100    0    0  100 / 1000    12.6s STM Gc test parallel
@jmid jmid added the ocaml5-issue A potential issue in the OCaml5 compiler/runtime label Sep 3, 2024
@jmid jmid mentioned this issue Sep 3, 2024
@jmid
Copy link
Collaborator Author

jmid commented Dec 20, 2024

Closing this as it is fixed in both 5.2.1, in the upcoming 5.3, and on trunk.

@jmid jmid closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ocaml5-issue A potential issue in the OCaml5 compiler/runtime
Projects
None yet
Development

No branches or pull requests

1 participant