Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidateDDOCommand - getValidationSignature only for authentificated requests #816

Open
alexcos20 opened this issue Jan 22, 2025 · 0 comments · May be fixed by #835
Open

ValidateDDOCommand - getValidationSignature only for authentificated requests #816

alexcos20 opened this issue Jan 22, 2025 · 0 comments · May be fixed by #835
Assignees
Labels
Type: Bug Something isn't working

Comments

@alexcos20
Copy link
Member

alexcos20 commented Jan 22, 2025

When calling ValidateDDOCommand we always add our signature if the DDO is valid, no matter who is the published. In order to implement the concept of isolated markets, we need to change that.

So, we will add our signature ONLY IF:

  • command contains optional parameter publisherAddress
  • command contains optional parameter nonce and nonce is valid for publisherAddress
  • command contains optional parameter signature which is the signed message based on nonce by publisherAddress
  • ddo.nftAddress exists and it's valid
  • publisherAddress has updateMetadata role on ddo.nftAddress contract
  • publisherAddress has publishing rights on this node (see DDO Index: Isolated node #815)
@alexcos20 alexcos20 added the Type: Bug Something isn't working label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants