Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl IntoExecutablePath for camino paths? #90

Open
sunshowers opened this issue Feb 25, 2021 · 3 comments · May be fixed by #91
Open

impl IntoExecutablePath for camino paths? #90

sunshowers opened this issue Feb 25, 2021 · 3 comments · May be fixed by #91

Comments

@sunshowers
Copy link

Hey Jack, been a while! hope you're doing well :)

We released https://github.com/withoutboats/camino recently which adds UTF-8 path types. The readme explains the advantages of using it -- I was wondering if you think implementing IntoExecutablePath for Utf8Path and Utf8PathBuf would be reasonable (perhaps behind a feature flag).

Thanks!
@oconnor663
Copy link
Owner

I only have time to write a brief comment at the moment, but I just want to say that this sounds like a good idea, and I would've been really nice to know about camino when I was writing this mess: https://github.com/BLAKE3-team/BLAKE3/blob/master/b3sum/what_does_check_do.md :)

@sunshowers
Copy link
Author

Yikes! Yeah camino would really help for that, wouldn't it.

I can submit a PR for this. Would you prefer camino be

  • always used
  • used with a default feature
  • used with a non-default feature?

@oconnor663
Copy link
Owner

Let's start with a non-default feature, if that's ok with you.

sunshowers added a commit to sunshowers/duct.rs that referenced this issue Feb 27, 2021
@sunshowers
add support for camino Utf8Path and Utf8PathBuf
9ed4a96 
Add support behind a non-default `"camino"` feature.

Closes oconnor663#90.
@sunshowers sunshowers linked a pull request Feb 27, 2021 that will close this issue
Open
sunshowers added a commit to sunshowers/duct.rs that referenced this issue Mar 19, 2021
@sunshowers
add support for camino Utf8Path and Utf8PathBuf
c5c07e9 
Add support behind a non-default `"camino"` feature.

Closes oconnor663#90.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for camino Utf8Path and Utf8PathBuf sunshowers/duct.rs
2 participants
@sunshowers @oconnor663