diff --git a/CHANGELOG.md b/CHANGELOG.md index bd3a75c2f..0ab98c4cc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ Please add a note of your changes below this heading if you make a Pull Request. * Ensure endstops update before being checked for errors, to prevent [#625](https://github.com/odriverobotics/ODrive/issues/625) * Reset trajectory_done_ during homing to ensure a new trajectory is actually computed [#634](https://github.com/odriverobotics/ODrive/issues/634) * Use `input_xxx` as a DC offset in tuning mode +* Syncs `steps_` with input pos when set explicitly via CAN. # Releases ## [0.5.4] - 2021-10-12 diff --git a/Firmware/MotorControl/axis.cpp b/Firmware/MotorControl/axis.cpp index d8579c5b2..a94ec6413 100644 --- a/Firmware/MotorControl/axis.cpp +++ b/Firmware/MotorControl/axis.cpp @@ -295,9 +295,7 @@ bool Axis::start_closed_loop_control() { return false; } else { controller_.pos_setpoint_ = *pos_init; - controller_.input_pos_ = *pos_init; - float range = controller_.config_.circular_setpoint_range; - steps_ = (int64_t)(fmodf_pos(*pos_init, range) / range * controller_.config_.steps_per_circular_range); + controller_.set_input_pos_and_steps(*pos_init); } } controller_.input_pos_updated(); diff --git a/Firmware/MotorControl/controller.cpp b/Firmware/MotorControl/controller.cpp index e17e86294..cbedb140c 100644 --- a/Firmware/MotorControl/controller.cpp +++ b/Firmware/MotorControl/controller.cpp @@ -87,6 +87,12 @@ bool Controller::anticogging_calibration(float pos_estimate, float vel_estimate) } } +void Controller::set_input_pos_and_steps(float const pos) { + input_pos_ = pos; + float const range = config_.circular_setpoint_range; + axis_->steps_ = (int64_t)(wrap_pm(pos, range) / range * config_.steps_per_circular_range); +} + void Controller::update_filter_gains() { float bandwidth = std::min(config_.input_filter_bandwidth, 0.25f * current_meas_hz); input_filter_ki_ = 2.0f * bandwidth; // basic conversion to discrete time diff --git a/Firmware/MotorControl/controller.hpp b/Firmware/MotorControl/controller.hpp index da19149ed..35036ab97 100644 --- a/Firmware/MotorControl/controller.hpp +++ b/Firmware/MotorControl/controller.hpp @@ -80,6 +80,8 @@ class Controller : public ODriveIntf::ControllerIntf { void start_anticogging_calibration(); bool anticogging_calibration(float pos_estimate, float vel_estimate); + void set_input_pos_and_steps(float pos); + void update_filter_gains(); bool update(); diff --git a/Firmware/communication/can/can_simple.cpp b/Firmware/communication/can/can_simple.cpp index 961d4c826..904af01cd 100644 --- a/Firmware/communication/can/can_simple.cpp +++ b/Firmware/communication/can/can_simple.cpp @@ -253,7 +253,7 @@ bool CANSimple::get_encoder_count_callback(const Axis& axis) { } void CANSimple::set_input_pos_callback(Axis& axis, const can_Message_t& msg) { - axis.controller_.input_pos_ = can_getSignal(msg, 0, 32, true); + axis.controller_.set_input_pos_and_steps(can_getSignal(msg, 0, 32, true)); axis.controller_.input_vel_ = can_getSignal(msg, 32, 16, true, 0.001f, 0); axis.controller_.input_torque_ = can_getSignal(msg, 48, 16, true, 0.001f, 0); axis.controller_.input_pos_updated();