diff --git a/README.md b/README.md index bc59f9f..0c89950 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ From the project root, build runnable `.jar` file (located in `cardea-server/tar Or run server via Maven (ensure config is in cardea-server): -mvn clean install && mvn spring-boot:run -pl cardea-server +`mvn clean install && mvn spring-boot:run -pl cardea-server` The server runs on port 8080 by default. To run on a different port, add a `server.port` setting to your `application.properties` diff --git a/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java b/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java index 7fac1dc..bdf3c53 100644 --- a/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java +++ b/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java @@ -195,10 +195,10 @@ private ShesmuSequencing makeShesmuSequencing(List samples, MetricCatego private boolean getQcFailed(Sample sample) { Run run = sample.getRun(); - return ((sample.getDataReviewPassed() == false) - || (sample.getQcPassed() == false) - || (run.getDataReviewPassed() == false) - || (run.getQcPassed() == false)); + return ((Boolean.FALSE.equals(sample.getDataReviewPassed())) + || (Boolean.FALSE.equals(sample.getQcPassed())) + || (Boolean.FALSE.equals(run.getDataReviewPassed())) + || (Boolean.FALSE.equals(run.getQcPassed()))); } private Set getLimsIusIdsForShesmu(Case kase) { diff --git a/changes/fix_qcfailed_field.md b/changes/fix_qcfailed_field.md new file mode 100644 index 0000000..d98e77b --- /dev/null +++ b/changes/fix_qcfailed_field.md @@ -0,0 +1 @@ +Field on cardea detailed cases must be able to handle null values \ No newline at end of file