Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exp// ExponentPushToken is a valid Expo push token type ExponentPushToken string #21

Open
filikos opened this issue Sep 9, 2021 · 1 comment
Open

Exp// ExponentPushToken is a valid Expo push token type ExponentPushToken string #21

filikos opened this issue Sep 9, 2021 · 1 comment

Comments

@filikos
Copy link

filikos commented Sep 9, 2021 •
edited
Loading 

// ExponentPushToken is a valid Expo push token
type ExponentPushToken string

Why does this type exist?
There is no receiver calls for ExponentPushToken, that type seems to be adding overhead when using the client.
A simple slice of strings would be enough in the PushMessage type.
@filikos filikos closed this as completed Sep 9, 2021
@filikos filikos reopened this Sep 9, 2021
@filikos
Copy link
Author

filikos commented Sep 9, 2021

@oliveroneill
I opened a PR for this simplification, please let me know if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filikos