-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: allowing httpx
version 0.28
#356
Comments
Hey @jamesbraza, thanks for bringing this up - we pin the version to not have unintended updates (like even the one you've mentioned) Will check this out a bit more bump the version! |
Hello @jamesbraza It also means some incompatibility with jupyterlab as well. |
breaks llm-ollama plugin install as well, due to conflicts |
Wouldn't this existing PR address this?: #365 I'm not familiar with python packaging but the failing jobs there look like trivial dependency SHA checking problems that are probably addressable with a quick CLI command. Happy to dig and and try that but I'm guessing a repo maintainer could get that done in moments. Would love to be able to use the llm-ollama plugin (taketwo/llm-ollama#23) |
Please consider merging the httpx dependency upgrade #365 so users of llm-ollama can continue using Ollama through their favorite CLI. |
Can I kindly ask for an httpx version bump too? With everyone else starting to require httpx 0.28.x it's becoming literally impossible to use python-ollama in any somewhat sophisticated data analytics environment. And I would really hate to nuke my perfectly fine working ollama setup and move back to hugging face transformers, just because of a small version conflict. |
Now that httpx has been upgraded to 0.28.1, can a release be created so that projects depending on this package can use httpx 0.28.1? |
Yes, cutting a release today! @Diegorro98 |
https://github.com/ollama/ollama-python/releases/tag/v0.4.7 🥳 Sorry for the delay everyone! Going to be looking into loosening these deps a bit! |
https://github.com/encode/httpx/releases/tag/0.28.0 comes with some breaking changes, mainly on
httpx.AsyncClient
'sapp
argument.Trying to pull it in, I get blocked by
ollama
because it downpinshttpx
: https://github.com/ollama/ollama-python/blob/v0.4.2/pyproject.toml#L13Can we move
httpx = "^0.27.0"
tohttpx = ">=0.27"
The text was updated successfully, but these errors were encountered: