You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This happens because 7-zip or node-7z sometimes gives as extracted an file/image while it is still writing it to disk, so OpenComic starts generating the thumbnail with the partially extracted image. Previously in v1.2.0, in this cases the thumbnails were not generated, since the library used for images (sharp) provides an error if the image is corrupted, but in v1.3.0 I enabled in sharp an option to force work in corrupted images to fix this, I did some testing and it seemed to generate thumbnails correctly, but it only seems to do so for progressive JPGs and not regular PNGs or JPGs.
With the new fix, the behavior is now the following.
The thumbnail is generated with the work in corrupted images option disabled.
If it gives an error, it is tried again after a 100 milliseconds 2 more times.
If the thumbnail still cannot be generated, it tries once more time but with the option to work in corrupted images enabled.
Preflight Checklist
OpenComic Version
1.3.1
Operating System
WIN 10 22H2 19045.3324
Installed via
.exe
Steps to reproduce
export cbz files, open the library
Expected Behavior
correct thumnails for all files
Actual Behavior
incorrect / 'area repeateated' thumbnails for some files
Error message
None
Additional Information
I remember this will not happen on 1.2.0 version app
Sample file
No response
The text was updated successfully, but these errors were encountered: