Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation issues #29

Open
giocomai opened this issue Jun 28, 2024 · 2 comments
Open

Translation issues #29

giocomai opened this issue Jun 28, 2024 · 2 comments
Assignees

Comments

@giocomai
Copy link

giocomai commented Jun 28, 2024

There are some issues with the translation of the (very nice) Freedom theme.

In some cases, the issue is clear, as the theme requests the translation, but the string is not available, e.g.

'Showing %1$s to %2$s of %3$s %4$s'
'< Previous page'
'Next page >'

or, in the theme settings page, for example the following are missing:

  • List
  • Toggle (default: grid)
  • Toggle (default: list
    (but "Grid" exists in Omeka core translations, and is thus translated, which is good, but looks a bit odd without the others)

In the settings, all of Truncate Body Property options are missing, and actually, most of the setting page remains untranslated.

Should these be added to Omeka core translation files in Transifex?

In other cases, the translation would be available, but the value is hardcoded in the theme, e.g. the hardcoded "advanced search" in header.phtml, which can be easily fixed (this one is currently very visible, as it is by default at the top of any website using the theme).

There is also the "go" button of the pagination (pagination.phtml)
<input type="submit" class="gotopage-btn" value="Go">

Finally, there are untranslated text string also in javascript files, in particular in accordion.js, "Expand all" and "Collapse all", which appears when listing related resources.

I may be missing others.

@nelsonamaya82 nelsonamaya82 self-assigned this Jul 4, 2024
@nelsonamaya82
Copy link
Collaborator

@giocomai thanks for reporting this, I'll start reviewing it with the team.

@giocomai
Copy link
Author

giocomai commented Aug 1, 2024

I found other untranslated strings in navigation.js:

  • Previous Menu
  • Close Menu

If I find others, I will edit this comment.

As a note, I noticed that pages already load a Omeka.jsTranslate = function(str), wich references js_translate_strings in the core codebase, so I suppose that could be a way to got about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants