Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Clean up unit tests #69

Open
smartcontracts opened this issue Mar 20, 2018 · 4 comments
Open

Clean up unit tests #69

smartcontracts opened this issue Mar 20, 2018 · 4 comments
Labels

Comments

@smartcontracts
Copy link
Contributor

Our tests are starting to become extremely large. We should clean things up so they're easier to read and understand.

test_root_chain.py seems like a good place to start.

@hamdiallam
Copy link

why not make the rootchain smart contract isolated in a truffle project and use mocha to test. A suggestion

@jeamick
Copy link

jeamick commented Jul 18, 2018

hello @kfichter ,

Any update about what @hamdiallam mentioned ?

What do you mean by clean up unit tests ?

Maybe having separated python test with Several folder could improve readability ?

Thanks for your response

@smartcontracts
Copy link
Contributor Author

I'm very much considering this! I'm going to discuss it further with a few people, but it seems like it'd be most useful to have the contracts as a truffle project and the client as something separate. The original motivation was to share the core components (plasma_core) to avoid duplicating work.

@kasima
Copy link
Contributor

kasima commented Jul 19, 2018

I like this plan. This would be a good place to start with truffle and move the work over to the plasma-contracts repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants