Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect holidays #29

Closed
papampi opened this issue Oct 23, 2019 · 4 comments
Closed

Incorrect holidays #29

papampi opened this issue Oct 23, 2019 · 4 comments

Comments

@papampi
Copy link

papampi commented Oct 23, 2019

First I should thank you for your awesome calendar,

Then, looks like holidays are outdated,
For example, We have 2 holidays next week on 5th and 7th of Aban, but none marked in it.

@omid
Copy link
Owner

omid commented Oct 23, 2019

Thanks :-)

At least in this specific place, holidays are fine in the code

The problem is the Gregorian-to-Hijri converter which returns 29 days for Safar!
So seems like it's time to change the library to something else!

@omid
Copy link
Owner

omid commented Oct 23, 2019

Most converters out there are based on http://www.staff.science.uu.nl/~gent0113/islam/ummalqura_converter.htm which shows Safar as 29-day month this year!

@papampi
Copy link
Author

papampi commented Oct 23, 2019

I know it must be such a headache to convert these dates while Iranian gov keeps changing them based on watching the moon for Eid-e-Fetr.

@omid
Copy link
Owner

omid commented Apr 22, 2020

Closed because it's duplicate of #11

@omid omid closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants