problem with search in Type INT for NumberColumn

[Chris53897]

The NumberColumn does a check it it is valid for search. It checks with is_numeric.
https://github.com/omines/datatables-bundle/blob/master/src/Column/NumberColumn.php#L53

If the field is of type int, there is an error if you search for partial dates like 30.05 this is valid for is_numeric().
But that will raise an error.

An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: "30." LINE 1: ...ce_name) LIKE '%30.%'

Possible solution.
Check if type is int and change the check.
Or a new ColumnType?

<?php 
namespace App\DataTable\Column;

use Omines\DataTablesBundle\Column\NumberColumn;

class IntColumn extends NumberColumn
{
    public function isValidForSearch(mixed $value): bool
    {
        # Filter out "." like in dates d.m.Y
        if(str_contains($value, '.'))
        {return false;}

        return is_numeric(trim($value));
    }
}

[github-actions]

Stale issue message

[Chris53897]

Still relevant. But there are more cases to handle like. +12123 or -1231313 or over/under max INT_VALUES

[curry684]

I believe the correct course of action would be to override leftExpr and rightExpr for NumberColumn as the real problem is that one shouldn't just call LIKE on numeric fields.

[mice6]

I believe the correct course of action would be to override leftExpr and rightExpr for NumberColumn as the real problem is that one shouldn't just call LIKE on numeric fields.

why do you think so? for numeric fields we should be able to do range, same for DateTime fields.

[curry684]

Fair enough, but point remains that LIKE is flat out wrong.

[github-actions]

Stale issue message