Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p communication data should be strongly typed #49

Open
wxf4150 opened this issue Dec 2, 2021 · 1 comment
Open

p2p communication data should be strongly typed #49

wxf4150 opened this issue Dec 2, 2021 · 1 comment
Assignees
@feiben @neocarmack @obdCoder
Labels
vulnerability something gets attack

Comments

@wxf4150
Copy link
Collaborator

wxf4150 commented Dec 2, 2021 •
edited
Loading

The data type of p2p communication is not strongly typed. At present, using one ~ char to split the data stream, using gjson to extract json data is not safe enough; it should be possible to use protobuf to do complete and strongly typed data extraction. The data stream separator should be longer to reduce potential segmentation errors, maybe three '~' char will better.
@neocarmack
Copy link
Member

yes. It is a problem. We are now integrating with the latest omnicore, this issue should be fixed accordingly.

@neocarmack neocarmack changed the title p2p communication should strongly typed p2p communication data should be strongly typed Dec 2, 2021
@neocarmack neocarmack added the vulnerability something gets attack label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feiben feiben

@neocarmack neocarmack

@obdCoder obdCoder

Labels
vulnerability something gets attack
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wxf4150 @feiben @neocarmack @obdCoder