Travis ci #27
Closed
Travis ci #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Json data through GET doesn't work correctly
|
i don’t understand. Obd no longer needs full node, so why re-activate [chainNode] in configure/conf.ini? [chainNode] is already deprecated. |
|
There are deep conflict in this PR. We will change the way of GET to POST in the next version of obd. and in the configure of tracker (tracker/config/conf.ini), there is your own chainnode config for your local omnicore instance, which should not be merged into main codebase. And there are some other points we need to review for this PR. |
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6