Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[delivery-service] - make CORS-Headers stricter #304

Open
ccwienk opened this issue Jan 2, 2025 · 0 comments
Open

[delivery-service] - make CORS-Headers stricter #304

ccwienk opened this issue Jan 2, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@ccwienk
Copy link
Collaborator

ccwienk commented Jan 2, 2025

Context / Motivation

Delivery-Service and Delivery-Dashboard are typically deployed in such a way that they are served from different (sub-)domains. Because this makes requests from Delivery-Dashboard cross-domain-requests, Delivery-Service needs to set "CORS-Headers". Currently, it sets those for any domain (*), which is not a recommended practise.

Implementation Proposal

Make domain(s) for which Delivery-Service set CORS-Headers configurable. Configure OCM-Gear-Installer such that it will by default restrict CORS-Domains to the one from which Delivery-Dashboard will be served. It should remain possible for users to overwrite this default.

@ccwienk ccwienk added the enhancement New feature or request label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant