Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more defensive creation of ComponentDescriptor names #307

Open
dee0sap opened this issue Oct 28, 2024 · 0 comments
Open

Need more defensive creation of ComponentDescriptor names #307

dee0sap opened this issue Oct 28, 2024 · 0 comments
Labels
area/ipcei Important Project of Common European Interest kind/bugfix Bug kind/task small task, normally part of feature or epic

Comments

@dee0sap
Copy link

dee0sap commented Oct 28, 2024

What happened:

I reviewed the code for component:ConstructUniqueName and found it wanting as it doesn't defend

  • against generated names being longer than kubernetes allows
  • characters that are allowed in semantic versioning, e.g. '+', but not allowed in kubernetes names

What you expected to happen:
component:ConstructUniqueName should defend against both of the conditions above

How to reproduce it (as minimally and precisely as possible):
Produce a componetversion where the component name is near the limit allowed for kubernetes object names and/or try to use a version that uses characters that are allowed in semantic versioning but not in kubernetes object names

Anything else we need to know:
Nope

Environment:
Current version of OCM-Controller running in a Gardener cluster

@dee0sap dee0sap added kind/bugfix Bug kind/task small task, normally part of feature or epic labels Oct 28, 2024
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei Important Project of Common European Interest kind/bugfix Bug kind/task small task, normally part of feature or epic
Projects
Status: 🆕 ToDo
Development

No branches or pull requests

1 participant