Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace module https://pkg.go.dev/github.com/juju/fslock with something else because of LGPL license #1174

Closed
2 tasks
morri-son opened this issue Dec 6, 2024 · 0 comments · Fixed by #1176
Closed
2 tasks
Assignees
Labels
area/ipcei Important Project of Common European Interest kind/feature new feature, enhancement, improvement, extension
Milestone

Comments

@morri-son
Copy link
Contributor

morri-son commented Dec 6, 2024

What would you like to be added:
https://github.com/open-component-model/ocm/blob/main/api/utils/filelock/lock.go uses package https://pkg.go.dev/github.com/juju/fslock. This package is licensed under LPGL which is very restrictive. We must replace this usage with different library, e.g.
https://github.com/rogpeppe/go-internal/blob/master/lockedfile/lockedfile.go

Why is this needed:
Static linking with LGPL libraries changes the licensing landscape significantly:

LGPL Static Linking Requirement:

When statically linking LGPL libraries, you must either:

  • Provide the full source code of your application
  • Provide a mechanism for users to replace the library
  • Potentially release your entire application under LGPL

Practical Implications:

  • This could require open-sourcing your entire application
  • Significant compliance burden for commercial use
  • Potential legal risks if not handled correctly

**Tasks

  • Replace library
  • Update ./NOTICE file in the repository and remove the part for the LGPL lib
@morri-son morri-son added the kind/feature new feature, enhancement, improvement, extension label Dec 6, 2024
@morri-son morri-son added this to the 2024-Q4 milestone Dec 6, 2024
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Dec 6, 2024
@morri-son morri-son moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board Dec 6, 2024
@Skarlso Skarlso moved this from 📋 Next-UP to 🏗 In Progress in OCM Backlog Board Dec 6, 2024
@Skarlso Skarlso self-assigned this Dec 6, 2024
@hilmarf hilmarf closed this as completed in c51453b Dec 8, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to 🍺 Done in OCM Backlog Board Dec 8, 2024
@ocmbot ocmbot bot moved this from 🍺 Done to 🔒Closed in OCM Backlog Board Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei Important Project of Common European Interest kind/feature new feature, enhancement, improvement, extension
Projects
Status: 🔒Closed
Development

Successfully merging a pull request may close this issue.

2 participants