Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ocm github organization teams #1258

Open
fabianburth opened this issue Jan 16, 2025 · 1 comment
Open

Clean up ocm github organization teams #1258

fabianburth opened this issue Jan 16, 2025 · 1 comment
Assignees
Labels
area/cicd Continuous Integration and Continuous Deployment related area/community Community related area/ipcei Important Project of Common European Interest area/security Security relevant
Milestone

Comments

@fabianburth
Copy link
Contributor

Why do we need this?

Currently, the team typically used (e.g. for requesting reviews) - Maintainers - also contains the OCM Gear team and other people that do not have to care about this.
Furthermore, there are teams like ocm-cli-team/ocm-cli-admin that are just @fabianburth, @morri-son, and @morrison-sap or ocm-core-team/ocm-core-admin that are just @fabianburth and @morrison-sap.

In conclusion, the teams really need a clean up.

@fabianburth fabianburth added area/cicd Continuous Integration and Continuous Deployment related area/community Community related area/security Security relevant labels Jan 16, 2025
@fabianburth fabianburth moved this to 📋 Next-UP in OCM Backlog Board Jan 16, 2025
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Jan 16, 2025
@fabianburth fabianburth moved this from 📋 Next-UP to 🆕 ToDo in OCM Backlog Board Jan 16, 2025
@morri-son
Copy link
Contributor

morri-son commented Jan 16, 2025

The project specific Teams have been created by OSPO team by default, when creating new OS repos. I deleted them now as we have teams valid for the whole Org / specific group of repos (OCM Gear Teams). These teams are added to all relevant OCM repos now:

  • Admins (Org and repos) with "admin" permission on repos
  • Maintainers with "maintain" permission on repos
  • Collaborators with "triage" permission on repos

The Admins team has the OSPO team as sub-team, the Collaborators team has the CNLM team and the OCM Gear team as sub-team.

The Maintainers are added as generic CODEOWNERS to all repos, but the .github repo. Inside of .github the CODEOWNERS look like this

# Default owners for everything in the repo.
# Unless a later match takes precedence, the Maintainers team
# will be requested for review when someone opens a pull request.
*       @open-component-model/Maintainers

# Especially for the shared git-repository settings in .github directory
/.github/            @open-component-model/Admins

# Owners for specific directories and files
/.github/workflows/  @open-component-model/Maintainers
/.github/ISSUE_TEMPLATE/  @open-component-model/Maintainers
/.github/pull_request_template.md  @open-component-model/Maintainers

once PR open-component-model/.github#19 has been merged (@fabianburth please do so 😉 and then close this issue. I'll set the status of the issue on the board to "review").

@morri-son morri-son moved this from 🆕 ToDo to 🔍 Review in OCM Backlog Board Jan 16, 2025
@morri-son morri-son added this to the 2025-Q1 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd Continuous Integration and Continuous Deployment related area/community Community related area/ipcei Important Project of Common European Interest area/security Security relevant
Projects
Status: 🔍 Review
Development

No branches or pull requests

2 participants