doc: add detail to confmap watcher #12150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsains
requested review from
mx-psi,
evan-bradley and
a team
as code owners
mattsains
force-pushed
the
watcher-docs
branch
2 times, most recently
from
ba832d9 to
f833595
Compare
mattsains
force-pushed
the
watcher-docs
branch
from
f833595 to
b6bb7b3
Compare
|
I can write a CHANGELOG entry for this, but I don't think it's helpful. Let me know if I should anyway to get the CI to pass |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12150 +/- ##
==========================================
+ Coverage 91.73% 91.76% +0.03%
==========================================
Files 463 463
Lines 24819 24809 -10
==========================================
- Hits 22767 22766 -1
+ Misses 1670 1659 -11
- Partials 382 384 +2 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Jan 22, 2025
mattsains
force-pushed
the
watcher-docs
branch
from
6d111b9 to
8936f98
Compare
mx-psi
approved these changes
Jan 23, 2025
evan-bradley
approved these changes
Jan 23, 2025
|
@bogdandrutu Could you double check this since you designed this in the first place? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to improve the docs on watchers based on the issue below
Link to tracking issue
Fixes #12115
Documentation
Clarified some code comments that were incorrect (there's no Retrieved.Get method) and included a new code sample for a Provider that uses the watcher func