Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor submission execution #2704

Open
MrSerth opened this issue Dec 13, 2024 · 0 comments
Open

Refactor submission execution #2704

MrSerth opened this issue Dec 13, 2024 · 0 comments
Labels
enhancement ruby Pull requests that update Ruby code

Comments

@MrSerth
Copy link
Member

MrSerth commented Dec 13, 2024

It would be great to refactor the current submission execution and make the components easier reusable. Currently, running and scoring are the main two methods supported by a Submission object. However, they should (ideally) only differ in the command used and otherwise be rather similar.

The current implementation is rather different between both (run and score). This is caused by the interactivity present for run, but absent for score. Let's refactor the execution, so that both methods are similar. This not only includes the methods itself, but also storing the testrun execution output (Testrun and TestrunMessage).

@MrSerth MrSerth added enhancement ruby Pull requests that update Ruby code labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

1 participant