Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dbus active read for thermal sensors #7

Open
mgersh opened this issue Feb 19, 2019 · 4 comments
Open

Use dbus active read for thermal sensors #7

mgersh opened this issue Feb 19, 2019 · 4 comments

Comments

@mgersh
Copy link

mgersh commented Feb 19, 2019

Right now they're built as passive read sensors, so when the value doesn't change in a while, they go into failsafe mode.

@feistjj
Copy link
Member

feistjj commented Feb 19, 2019

If this changes it needs to be configurable. We rely on this so that if a sensor stops responding it can be treated as an error and properly boost the fans.

@mgersh
Copy link
Author

mgersh commented Feb 19, 2019

How are you handling the case of sensors not changing for a while? Long timeouts?

@feistjj
Copy link
Member

feistjj commented Feb 19, 2019

We're using dbus-sensors project not phosphor-hwmon, I'm not sure of the behavior of phosphor-hwmon but dbus-sensors keep an async handle on the file descriptor and update the value for any change, so it hasn't been an issue yet. We also don't have any host pushed sensors.

@madscientist159
Copy link

We need this option as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants