Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkId D-Bus interface data type is int32_t, not uint32_t #46

Open
Peng85282 opened this issue Dec 24, 2024 · 1 comment
Open

NetworkId D-Bus interface data type is int32_t, not uint32_t #46

Peng85282 opened this issue Dec 24, 2024 · 1 comment

Comments

@Peng85282
Copy link

As shown below, the .NetworkId signature is 'i', which is int32_t. However, common/types.hpp defined it as uint32_t.

# busctl introspect xyz.openbmc_project.MCTP /xyz/openbmc_project/mctp/1/9
NAME                                TYPE      SIGNATURE RESULT/VALUE                           FLAGS
au.com.CodeConstruct.MCTP.Endpoint  interface -         -                                      -
.Remove                             method    -         -                                      -
.SetMTU                             method    u         -                                      -
org.freedesktop.DBus.Introspectable interface -         -                                      -
.Introspect                         method    -         s                                      -
org.freedesktop.DBus.Peer           interface -         -                                      -
.GetMachineId                       method    -         s                                      -
.Ping                               method    -         -                                      -
org.freedesktop.DBus.Properties     interface -         -                                      -
.Get                                method    ss        v                                      -
.GetAll                             method    s         a{sv}                                  -
.Set                                method    ssv       -                                      -
.PropertiesChanged                  signal    sa{sv}as  -                                      -
xyz.openbmc_project.Common.UUID     interface -         -                                      -
.UUID                               property  s         "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" const
xyz.openbmc_project.MCTP.Endpoint   interface -         -                                      -
.EID                                property  y         9                                      const
.NetworkId                          property  i         1                                      const
.SupportedMessageTypes              property  ay        4 0 8 1 5                              const

@Peng85282
Copy link
Author

Peng85282 commented Dec 24, 2024

Well, I did a little more research, and noticed this "recent" commit that changed the type of NetworkId and EID.

The introspect above shows the new EID type but old NetworkId type. I don't know how exactly this D-Bus interface is generated. Maybe I pulled an intermediate code or somewhere the code forgot to be updated to match this recent change. Can someone help and find it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant