Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family vs Asset Model #1

Open
brandonkimbk opened this issue Oct 5, 2021 · 0 comments
Open

Family vs Asset Model #1

brandonkimbk opened this issue Oct 5, 2021 · 0 comments

Comments

@brandonkimbk
Copy link
Contributor

While trying to figure out how to expose CPU ID Family, Model, Stepping and Microcode information in bmcweb: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/46884

I saw that smbios-mdr was exposing information such as Quad-Core Intel Xeon processor 3200 Series as "Family" under the xyz.openbmc_project.Inventory.Item.Cpu interface.

static const std::map<uint8_t, const char*> familyTable = {
{0x1, "Other"},
{0x2, "Unknown"},
{0x10, "Pentium II Xeon processor"},
{0xa1, "Quad-Core Intel Xeon processor 3200 Series"},
{0xa2, "Dual-Core Intel Xeon processor 3000 Series"},
{0xa3, "Quad-Core Intel Xeon processor 5300 Series"},
{0xa4, "Dual-Core Intel Xeon processor 5100 Series"},
{0xa5, "Dual-Core Intel Xeon processor 5000 Series"},
{0xa6, "Dual-Core Intel Xeon processor LV"},
{0xa7, "Dual-Core Intel Xeon processor ULV"},
{0xa8, "Dual-Core Intel Xeon processor 7100 Series"},
{0xa9, "Quad-Core Intel Xeon processor 5400 Series"},
{0xaa, "Quad-Core Intel Xeon processor"},
{0xab, "Dual-Core Intel Xeon processor 5200 Series"},
{0xac, "Dual-Core Intel Xeon processor 7200 Series"},
{0xad, "Quad-Core Intel Xeon processor 7300 Series"},
{0xae, "Quad-Core Intel Xeon processor 7400 Series"},
{0xaf, "Multi-Core Intel Xeon processor 7400 Series"},
{0xb0, "Pentium III Xeon processor"},
{0xb3, "Intel Xeon processor"},
{0xb5, "Intel Xeon processor MP"},
{0xd6, "Multi-Core Intel Xeon processor"},
{0xd7, "Dual-Core Intel Xeon processor 3xxx Series"},
{0xd8, "Quad-Core Intel Xeon processor 3xxx Series"},
{0xd9, "VIA Nano Processor Family"},
{0xda, "Dual-Core Intel Xeon processor 5xxx Series"},
{0xdb, "Quad-Core Intel Xeon processor 5xxx Series"},
{0xdd, "Dual-Core Intel Xeon processor 7xxx Series"},
{0xde, "Quad-Core Intel Xeon processor 7xxx Series"},
{0xdf, "Multi-Core Intel Xeon processor 7xxx Series"},
{0xe0, "Multi-Core Intel Xeon processor 3400 Series"}

Looking at the Redfish Resource and Schema guide at https://www.dmtf.org/sites/default/files/standards/documents/DSP2046_2021.2.pdf

Section 6.86.6 at page 668, we see:

"Manufacturer": "Intel(R) Corporation",
"Model": "Multi-Core Intel(R) Xeon(R) processor 7xxx Series",
"ProcessorId": {
    "VendorId": "GenuineIntel",
    "IdentificationRegisters": "0x34AC34DC8901274A",
    "EffectiveFamily": "0x42",
    "EffectiveModel": "0x61",
    "Step": "0x1",
    "MicrocodeInfo": "0x429943"
},

According to this, it looks like instead of "Family" (which gets parsed as EffectiveFamily in bmcweb), we should really be adding this "Family" information to xyz.openbmc_project.Inventory.Decorator.Asset interface's .Model inventory, which is already mapped correctly in bmcweb https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/processor.hpp#L294-L302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant