Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework auth #299

Open
klafbang opened this issue Oct 28, 2024 · 0 comments
Open

Rework auth #299

klafbang opened this issue Oct 28, 2024 · 0 comments

Comments

@klafbang
Copy link
Collaborator

Current authentication relies on explicit login action and route guards. This is undesirable in many ways

  1. Bad UX: force many extra clicks: login button, login, navigate to desired page

  2. It is not possible to redirect to protected pages as they cannot exchange code for token

  3. Unreliable handling of token expiration (nothing will happen on frontend)

Guards are generally not desirable for this, it is much more user-friendly to handle login explicitly on pages.

For a MVP, I propose just unconditionally requiring login on all pages. Later we can refine this to support some pages without auth or pages visible both with and without.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant