Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireshark is not using qt5 anymore (by default) #844

Open
FederAndInk opened this issue Jul 18, 2024 · 2 comments
Open

wireshark is not using qt5 anymore (by default) #844

FederAndInk opened this issue Jul 18, 2024 · 2 comments

Comments

@FederAndInk
Copy link

When trying to build wireshark with qt5 packageconfig enabled, I get this error:

| CMake Error at CMakeLists.txt:1242 (find_package):
|   By not providing "FindQt6.cmake" in CMAKE_MODULE_PATH this project has
|   asked CMake to find a package configuration file provided by "Qt6", but
|   CMake did not find one.
|
|   Could not find a package conf-- Configuring incomplete, errors occurred!
| iguration file provided by "Qt6" with any of
|   the following names:
|
|     Qt6Config.cmake
|     qt6-config.cmake
|
|   Add the installation prefix of "Qt6" to CMAKE_PREFIX_PATH or set "Qt6_DIR"
|   to a directory containing one of the above files.  If "Qt6" provides a
|   separate development package or SDK, be sure it has been installed.
|
|
| WARNING: exit code 1 from a shell command.

Wireshark is now using qt6 by default, there appears to be an option to build for qt5 too. Maybe a modification to the qt5 packageconfig is needed? And qt6 could be added too?

See their cmake options: https://gitlab.com/wireshark/wireshark/-/blob/v4.2.6/CMakeOptions.txt?ref_type=tags
@FederAndInk
Copy link
Author

using this package config works (using -DUSE_qt6=OFF):

PACKAGECONFIG[qt5] = "-DENABLE_QT5=ON -DBUILD_wireshark=ON -DUSE_qt6=OFF, -DENABLE_QT5=OFF -DBUILD_wireshark=OFF, qttools-native qtmultimedia qtsvg"

I think adding a qt6 option while keeping the qt5 option would be great.

kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 2, 2024
@gmange @kraj
wireshark: fix Qt5/6 configuration
99dabd3 
Wireshark is built with Qt6 by default when Qt is enabled.
Forcibly disable Qt6 in our Qt5 PACKAGECONFIG

Github issue: openembedded#844

Reported-by: Ludovic Jozeau <[email protected]>
Reviewed-by: Yoann Congal <[email protected]>
Signed-off-by: Ghislain Mangé <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 3, 2024
@wangmingyu84 @kraj
rabbitmq-c: upgrade 0.14.0 -> 0.15.0
5e7c7df 
## Fixed
- Warning on MacOS about incompatible function declaration
- Logic when decoding AMQP data after bad data may cause crash (openembedded#837)
- Use SSL_get1_peer_certificate when compiling against OpenSSL 3+

## Changed
- Updates to various github actions.

## Added
- Add amqp_publisher_confirm_wait function (openembedded#841)
- Add amqp_literal_bytes macro (openembedded#844)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 3, 2024
@gmange @kraj
wireshark: fix Qt5/6 configuration
cc83b9a 
Wireshark is built with Qt6 by default when Qt is enabled.
Forcibly disable Qt6 in our Qt5 PACKAGECONFIG

Github issue: openembedded#844

Reported-by: Ludovic Jozeau <[email protected]>
Reviewed-by: Yoann Congal <[email protected]>
Signed-off-by: Ghislain Mangé <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 3, 2024
@wangmingyu84 @kraj
rabbitmq-c: upgrade 0.14.0 -> 0.15.0
700ca64 
## Fixed
- Warning on MacOS about incompatible function declaration
- Logic when decoding AMQP data after bad data may cause crash (openembedded#837)
- Use SSL_get1_peer_certificate when compiling against OpenSSL 3+

## Changed
- Updates to various github actions.

## Added
- Add amqp_publisher_confirm_wait function (openembedded#841)
- Add amqp_literal_bytes macro (openembedded#844)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
daregit pushed a commit to daregit/yocto-combined that referenced this issue Dec 5, 2024
@gmange @kraj
src/meta-openembedded:wireshark: fix Qt5/6 configuration
c2838bc 
Wireshark is built with Qt6 by default when Qt is enabled.
Forcibly disable Qt6 in our Qt5 PACKAGECONFIG

Github issue: openembedded/meta-openembedded#844

Reported-by: Ludovic Jozeau <ludovic.jozeausmile.fr>
Reviewed-by: Yoann Congal <yoann.congalsmile.fr>
Signed-off-by: Ghislain Mangé <ghislain.mangesmile.fr>
Signed-off-by: Khem Raj <raj.khemgmail.com>
@gmange
Copy link
Contributor

gmange commented Dec 5, 2024

Issue fixed on master :

  • wireshark: fix Qt5/6 configuration

https://git.openembedded.org/meta-openembedded/commit/?id=cc83b9ac17276c6ebb590a7e84e86239b9836e0f

  • wireshark: use inherit_defer for conditional cases

https://git.openembedded.org/meta-openembedded/commit/?id=97318e27ebf9f528acf77fb0759c332bd83adb4b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmange @FederAndInk