-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider item options for selection widget when no mapping is defined #912
Comments
Fixes openhab#912 Signed-off-by: Danny Baumann <[email protected]>
@lolodomo Is there a quick way to test this with the demo setup? |
There is an example sitemap in eclipse-archived/smarthome#4942 (comment). I recommend to check the rest api if the values are present. If not, you need to update your oh server. |
Yes, but AFAICT an item which is linked to a special channel with options support is needed. My question is whether there's a way to have such a channel without the need for special hardware support. |
No I don't think this is available in the demo sitemap. It requires using a binding that defines some options for a channel, either statically or dynamically. |
Which of the Netatmo channels does have options? I do have a Netatmo station, so that one would work well for testing for me. |
Your PR worked for me. Maybe @lolodomo can test it as well so you don't have to test it. |
Temperature trend and pressure trend. |
I don't see any trend channels either for the indoor or the outdoor sensor ... I guess this is some post-2.3 thing? If so, I'd like to rely on @mueller-ma 's testing :-) |
facepalm It appears when clicking 'Show more' ... stupid me. Thanks, I'll give that a try. |
* Rename OpenHABWidgetMapping to OpenHABLabeledValue. A mapping basically is a value with a UI label, so generalize the class name to be able to use it in other places later. Signed-off-by: Danny Baumann <[email protected]> * Add support for populating selection widget from item options. Fixes #912 Signed-off-by: Danny Baumann <[email protected]> * Simplify selection widget click handling. Signed-off-by: Danny Baumann <[email protected]> * Improve selection widget spinner click handling. Signed-off-by: Danny Baumann <[email protected]> * Improve variable naming. Signed-off-by: Danny Baumann <[email protected]>
As discussed in eclipse-archived/smarthome#4942 it would be cool to implement this feature in the Android app too.
I just implemented it in Basic UI and Classic UI; it was already present in Paper UI.
The text was updated successfully, but these errors were encountered: