Skip to content
This repository has been archived by the owner on May 23, 2019. It is now read-only.

[Code Improvement] Tidy up code. Make it more maintainable #286

Open
LuckyMallari opened this issue Jan 28, 2018 · 0 comments
Open

[Code Improvement] Tidy up code. Make it more maintainable #286

LuckyMallari opened this issue Jan 28, 2018 · 0 comments

Comments

@LuckyMallari
Copy link
Contributor

LuckyMallari commented Jan 28, 2018

Saw couple of code issues (dev, not run time) that can be improved

  • Move all in-line styles onto its own separate scss/css
  • Move directives out of *service.js files
  • Don't abuse $rootScope!
    • Create a HabpanelService instead.
  • Perhaps use an AMD/loader
  • Upgrade Angular
  • Use ES6
  • Create common, reusable components
  • Create separate .config/config.json files for dev/production
  • Create a Wiki
  • Use factories instead of literal objects
  • Possibly use a statemachine ($stateProvider) rather than $routeProvider

Any plan to use Angular2+ ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant