Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text about effective client id in DC API can probably be improved #399

Open
jogu opened this issue Jan 29, 2025 · 0 comments
Open

text about effective client id in DC API can probably be improved #399

jogu opened this issue Jan 29, 2025 · 0 comments
Labels
ISO_VirtualMeeting relevant for ISO OID4VP mdoc profile over DC API
Milestone

Comments

@jogu
Copy link
Collaborator

jogu commented Jan 29, 2025

https://openid.net/specs/openid-4-verifiable-presentations-1_0-24.html#dc_api_request says:

Image

It's not completely clear that the two highlighted sentences apply only in the case of unsigned requests. I think we should consider moving this whole paragraph to the unsigned request section.

https://openid.net/specs/openid-4-verifiable-presentations-1_0-24.html#appendix-B.3.4.1 says:

Image

I am not sure it is good to use "effective Client Identifier" here. Effective Client Identifier is only defined in the context of unsigned requests, so written like this is it possible for people to get confused as to what client id the wallet should use in signed requests. Possibly just removing 'effective' would solve it.

Mentioned by Martijn during the ISO mDL meeting today.

My understanding of the working group position is that the client id for signed requests is always the client_id parameter found in the request object. (With a possible exception for cases where the signature can't be validated depending on what happens with #395)

@jogu jogu added the ISO_VirtualMeeting relevant for ISO OID4VP mdoc profile over DC API label Jan 29, 2025
@Sakurann Sakurann added this to the Final 1.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISO_VirtualMeeting relevant for ISO OID4VP mdoc profile over DC API
Projects
None yet
Development

No branches or pull requests

2 participants