Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for missing BOT_GITHUB_TOKEN secret #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Dec 31, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement
    I created this PR to fix the failing GitHub Actions.## Description
    This PR improves the error handling in the lock-issue.yml GitHub Actions workflow. Previously, if the BOT_GITHUB_TOKEN secret was missing or incorrect, the workflow would fail with a "Bad credentials" error. This error message was not very descriptive and made it difficult to diagnose the issue.

With this change, if the BOT_GITHUB_TOKEN secret is missing, the workflow will fail with the error message "Error: BOT_GITHUB_TOKEN secret is not set." This makes it easier to diagnose and fix the issue.

Summary of Changes

  • Modified the github-token parameter of the lock-threads action in the lock-issue.yml workflow to include a check that the BOT_GITHUB_TOKEN secret is set. If the secret is not set, the workflow will fail with a descriptive error message.

Copy link
Contributor Author

sweep-ai bot commented Dec 31, 2023

Rollback Files For Sweep

  • Rollback changes to .github/workflows/lock-issue.yml
  • Rollback changes to .github/workflows/lock-issue.yml

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Dec 31, 2023
Copy link
Contributor Author

sweep-ai bot commented Dec 31, 2023

Sandbox Executions

  • Running GitHub Actions for .github/workflows/lock-issue.yml
Check .github/workflows/lock-issue.yml with contents:

Ran GitHub Actions for 79e79618594bf3b707a7abfc344f106624ba4453:

Copy link
Contributor Author

sweep-ai bot commented Dec 31, 2023

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run contributor-assistant/[email protected]
yielded the following error:
##[error]graphql call to get the committers details failed: HttpError: Bad credentials

Here are the logs:
CLA Assistant GitHub Action bot has started the process

Generating plan by analyzing files... (step 2/3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant