Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Technical Report] [Metrics] Working Cycle Upper Bound Metric #58

Closed
ccrock4t opened this issue Nov 16, 2023 · 2 comments · Fixed by #87
Closed

[Technical Report] [Metrics] Working Cycle Upper Bound Metric #58

ccrock4t opened this issue Nov 16, 2023 · 2 comments · Fixed by #87
Assignees
@ccrock4t
Labels
enhancement New feature or request metrics

Comments

@ccrock4t
Copy link
Collaborator

ccrock4t commented Nov 16, 2023 •
edited
Loading

Technical Report

The working cycle takes an upper bound that is relatively low (at the order of millisecond).

More Info

We need to have a metric recording the upper bound of a working cycle.
see below
@ccrock4t ccrock4t added the bug Something isn't working label Nov 16, 2023
@ccrock4t ccrock4t changed the title [Technical Report] Metrics: Working Cycle [Technical Report] [Metrics] Working Cycle Nov 16, 2023
@ccrock4t ccrock4t changed the title [Technical Report] [Metrics] Working Cycle [Technical Report] [Metrics] Working Cycle Upper Bound Metric Nov 16, 2023
@bowen-xu bowen-xu added the enhancement New feature or request label Nov 16, 2023
@ccrock4t
Copy link
Collaborator Author

ccrock4t commented Nov 30, 2023 •
edited
Loading

No need for metrics of the upper bound

Just ensure the working cycle has a short upper bound

@ccrock4t
Copy link
Collaborator Author

We can however add a metric to measure average time per cycle, or cycles per second, just for performance measurements

@ccrock4t ccrock4t mentioned this issue Jan 11, 2024
Merged
@ccrock4t ccrock4t linked a pull request Jan 11, 2024 that will close this issue
Working Cycle Metric #87
Merged
@ccrock4t ccrock4t self-assigned this Jan 11, 2024
@ccrock4t ccrock4t added metrics and removed bug Something isn't working labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccrock4t ccrock4t

Labels
enhancement New feature or request metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Working Cycle Metric opennars/OpenNARS-4
2 participants
@ccrock4t @bowen-xu