testing strategy

[waddella]

@maximilianmordig please join the discussion

[maximilianmordig]

Where is the discussion taking place?
This seems to be related to #37.

[waddella]

we also need unit tests. Please propose a design pattern to test the framework without accessing the internet.

[nikolas-burkoff]

Some thoughts here:

• Easier to test after Major refactor #83
• Adding more unit tests into code base - some functions in utils.R and branching_strategy.R are ready for testing - in other cases we can refactor out logic like done here - some added in
  Major refactor #83
• Add code into the github action to run some integration tests for example checking out the stageddeps.X packages and running install_deps, build, check etc. on them - issue Add end to end test into staged.deps github action #87
• The code using git doesn't know about the rest of the package (and can be tested separately - we could have a dummy repo or we could rely on above to check it's working) so we can mock out the git stuff to test the graph building - may want some small refactors to make that easier some of this done in Major refactor #83
• Having the option to choose a caching directory could then enable us to test parts of the code which use it - this is done in Major refactor #83
• Add validation tests to check argument validation is working on the main exported function - issue Add tests for invalid input arguments for main exported functions #89

[nikolas-burkoff]

Done - see comment above