Running the UpdateGradleWrapper recipe for a Gradle project without wrapper should generate a functioning wrapper JAR

[bmuschko]

What version of OpenRewrite are you using?

• Moderne CLI 3.26.2
• OpenRewrite v8.42.5

How are you running OpenRewrite?

Moderne CLI

What is the smallest, simplest way to reproduce the problem?

Clone a Gradle project that does not include a checked-in wrapper.

$ mod config recipes jar install org.openrewrite:rewrite-gradle:LATEST
$ git clone https://github.com/bmuschko/mod-gradle-wrapper.git
$ mod build .
$ mod run . --recipe=org.openrewrite.gradle.UpdateGradleWrapper
$ mod git apply . --last-recipe-run
$ cd gradle/wrapper
$ ls -l
-rw-r--r--@ 1 bmuschko  staff    0 Jan  9 14:21 gradle-wrapper.jar
-rw-r--r--@ 1 bmuschko  staff  287 Jan  9 14:21 gradle-wrapper.properties

What did you expect to see?

A functioning Gradle wrapper.

What did you see instead?

The generated wrapper JAR file has a size of zero bytes. Executing the build with the wrapper fails.

./gradlew tasks
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
Caused by: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain

Are you interested in [contributing a fix to OpenRewrite]

Not for this one

[shanman190]

This is peculiar.

@bmuschko, just to make sure, in your current location you are able to hit services.gradle.org, correct?

In the test bed, we have a test that handles this case including confirming that the wrapper jar itself is valid.
https://github.com/openrewrite/rewrite/blob/main/rewrite-gradle%2Fsrc%2Ftest%2Fjava%2Forg%2Fopenrewrite%2Fgradle%2FUpdateGradleWrapperTest.java#L102

[bmuschko]

Yes, I can reach services.gradle.org.

$ ping services.gradle.org
PING services.gradle.org (104.16.73.101): 56 data bytes
64 bytes from 104.16.73.101: icmp_seq=0 ttl=55 time=14.855 ms

[bmuschko]

@shanman190 Were you able to find out about the root cause?

[shanman190]

@bmuschko, I haven't yet. I'm hoping to look into that this afternoon.

[shanman190]

Ok, after doing some testing I've found the following:

• RewriteTest: ✅
• OSS Gradle plugin: ✅
• Moderne CLI: ❌

I'm pretty sure I know why the Moderne CLI is failing.

[bmuschko]

Great, thanks for looking into this. Apart from the Moderne CLI, I am seeing the same issue on the Sass where I call this recipe from another one. The root cause may be the same.

[shanman190]

@bmuschko, on the SaaS I was able to successfully add the Gradle wrapper to a Gradle project that lacked the wrapper initially.

https://app.moderne.io/commits/de828a2b-04e6-4768-a79c-6c7587a8890b

So for me, only the Moderne CLI is failing to work correctly.

[bmuschko]

@shanman190 I might be wrong here. That's what I thought had happened. I will try that again on my end.

[bmuschko]

@shanman190 I wrote a test case that implements RewriteTest and it looks like the size of the wrapper JAR is larger than zero bytes. So I'd assume that the the issue is specific to the Moderne CLI as of now.

[timtebeek]

Thanks both! I'll log a separate issue for the CLI, but I wonder if we have the same problem when using dryRun in the Maven and Gradle plugins, as that similarly creates a .patch file that would then have to include the binary added here. 🤔

[shanman190]

@timtebeek, the answer there is yes. If you do a dryRun, then try to apply the Git patch any Remote elements will end up with empty files because the patch doesn't contain their content.