Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New OpenStreetMap Carto release, v4.24.0 #256

Closed
jeisenbe opened this issue Oct 25, 2019 · 11 comments
Closed

New OpenStreetMap Carto release, v4.24.0 #256

jeisenbe opened this issue Oct 25, 2019 · 11 comments

Comments

@jeisenbe
Copy link

A new version of OpenStreetMap Carto, v4.24.0 (https://github.com/gravitystorm/openstreetmap-carto/releases/tag/v4.24.0), has been released.

There are no major changes required

@kocio-pl
Copy link

Please wait with a deployment, it seems like we have some misunderstanding regarding one of the biggest changes.

@HolgerJeromin
Copy link
Contributor

Probably ref gravitystorm/openstreetmap-carto#3930 (comment)

@jeisenbe
Copy link
Author

Is this a significant enough issue to prevent deployment? I believe the concern in gravitystorm/openstreetmap-carto#3930 (comment) is a matter of opinion. It is not than a serious bug which would impact usability for mappers or map users.

@kocio-pl
Copy link

It's a blocker for me.

@kocio-pl
Copy link

I gave my long comment and proposition of what to do next here: gravitystorm/openstreetmap-carto#3930 (comment). Reverting one change might be made quite fast, if you insist on fast deployment.

@jeisenbe
Copy link
Author

It's a blocker for me

This statement, and the comments in gravitystorm/openstreetmap-carto#3930 (comment) are statements of opinion, based on subjective dislike of "water borders are sharp", which is a basic feature of the OpenStreetMap data model and Openstreetmap-Carto's method of representing features in a way that shows the underlying data clearly.

It is incorrect to suggest that release v4.24.0 is not ready for deployment.

@kocio-pl
Copy link

It's one thing to misunderstand (it's a human thing I can undertand) and the other to push this error further down the line when you're aware of this, it undermines my faith that this is done in a good faith.

I believe making half baked big changes "just for a test" (?) is a disservice for the users. Could you please explain why you need the deploy to happen exactly right now?

@kocio-pl
Copy link

representing features in a way that shows the underlying data clearly.

I don't believe it's that simple. What about rendering exact (thin) lines for rivers and roads instead of areas?

@jeisenbe
Copy link
Author

I am not trying to do anything in bad faith or make any changes for which there is no consensus.

Based on the recent comments, I understood that we had consensus on merging the changes in #3930.

The new issue is whether additional changes need to be made before a release to further improve the esthetic appearance.

That does not appear to be a sufficient reason to revert the change or the delay the release, in my opinion.

But I think we should discuss this with the other contributors to Openstreetmap-Carto at gravitystorm/openstreetmap-carto#3939 and come to an agreement there.

@kocio-pl
Copy link

Based on the recent comments, I understood that we had consensus on merging the changes in #3930.

The consensus was just on the principle (this is exactly what you have asked), not the actual code. You just misunderstood then that we agree on the code. This does not change the lack of consensus then and now.

The new issue is whether additional changes need to be made before a release to further improve the esthetic appearance.

My last comment was not about esthetics:

it becomes more important that people don't see artificial strong lines if they decide the line should be long. They should be not pushed by visual solution which is suitable only for small borders (and even then it's inferior).

@jeisenbe
Copy link
Author

https://github.com/gravitystorm/openstreetmap-carto/releases/tag/v4.24.1 - v4.24.1 is now released, resolving the concerns above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants