Corrupt meta tiles not refreshed

[woodpeck]

If for any reason a meta tile on disk is broken, mod_tile will return a 404 error to the client and not attempt to re-render the broken tile (unless/until it is considered "old"). It might make sense to change that, and instead attempt a re-render if encountering a broken meta tile.

[stephankn]

Sounds like a good idea.

I assume we have no idea on how meta tiles got corrupted in the beginning. Is there a way to scan the tile store for broken tiles?

[woodpeck]

The place where such a call should be made is probably

mod_tile/src/mod_tile.c

Line 1550 in 50afe3e

ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, "Failed to read tile from disk: %s", err_msg);

Most broken tiles I have witnessed were the result of a disk full condition. In 95% of cases they would be 0-byte files which can easily be cleaned up with a "find" operation, but at least for the tirex backend it is possible that a truncated meta tile gets created (openstreetmap/tirex#51). It is possible that the problem does not exist for renderd at all but still people could copy meta tiles from one box to the other or find other means to create broken meta tiles.