Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes are missing and return error 500 #3917

Closed
tordans opened this issue Feb 3, 2023 · 8 comments
Closed

Notes are missing and return error 500 #3917

tordans opened this issue Feb 3, 2023 · 8 comments

Comments

@tordans
Copy link
Contributor

tordans commented Feb 3, 2023

URL

https://www.openstreetmap.org/note/3533103

How to reproduce the issue?

A

  1. Open https://www.openstreetmap.org/note/3533103
  2. ==> Error 500, should be a node

B

  1. Open https://www.openstreetmap.org/note/3540073#map=17/52.47257/13.43322&layers=N
  2. ==> Should have more than 1 open node

API returns one https://www.openstreetmap.org/api/0.6/notes.json?bbox=13.429101705551147,52.47160590360475,13.440345525741579,52.47378871279819

It looks like, only notes created recently are visible, but older active notes are not.


FYI @SupaplexOSM

Screenshot(s) or anything else?

No response

@tordans
Copy link
Contributor Author

tordans commented Feb 3, 2023

Update: This App shows the node https://ent8r.github.io/NotesReview/?view=map&map=16%2F52.4728%2F13.4338&bbox=13.4188%2C52.4705%2C13.4488%2C52.4751&apply-bbox=true&status=all&anonymous=hide

But clicking on "open on osm org" results in the error above.

@tordans
Copy link
Contributor Author

tordans commented Feb 3, 2023

Update 2:

It looks like this might be two issue…

1

The node above is created by a user account that was not supposed to do anything than hold OSMCha filter. This account is currently blocked. osmberlin_changeset_review. So this is the blocked-user-node-broken issue (a Duplicate).

NOW the node is visible, because Supaplex030 commented…

2

But we also have JS Errors Uncaught TypeError: Cannot read properties of undefined (reading 'text'). At this point the API response in the inspector showed about 10 notes for my bbox but only one was visible.

@tordans
Copy link
Contributor Author

tordans commented Feb 3, 2023

Update 3:

Now all is visible again. No JS Errors.

Super weird, I will close this for now …

@tordans tordans closed this as completed Feb 3, 2023
@AntonKhorev
Copy link
Collaborator

This is not going to get fixed because #3831

@tomhughes
Copy link
Member

This will be a duplicate of #2146 and #3831 is the plan for fixing it - the first part (#3911) was merged this week.

@AntonKhorev
Copy link
Collaborator

js errors are fixed in #3617 but fixing them is not part of plans because "The output of the API has to remain the same for now"

@gravitystorm
Copy link
Collaborator

fixing them is not part of plans

That's not true.

@AntonKhorev
Copy link
Collaborator

That's not true.

Are you going to change the API, like adding a guarantee that there's at least one comment per note?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants