Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expiremeta.pl causes duplicate touch operations of same metatile file #21

Open
stephankn opened this issue Mar 14, 2021 · 0 comments
Open

Comments

@stephankn
Copy link
Contributor

I am currently checking whether to renew my 10 years old rendering stack. I had a closer look at expiremeta.pl and noticed that it touched files way more often than expected.

On my test setup I had in total 5 metatile files. Still the script issued 960 touch operations.
Unless this is fully covered by OS level filesystem cache, it can cause i/o problems. Calling the touch command unnecessary often also probably not the best in terms of performance.

Probably the script should collect metatile files to touch in a "unique" data structure and then touch only once.

To reproduce create a tile store with very few meta-tiles and feed in a larger expiry output from osm2pgsql. Attached are my input files and a console output where I print each touch command.
tirex-expiremeta-repro.zip

@stephankn stephankn changed the title expiremeta.pl causes duplicate touch operations of same metatile fille expiremeta.pl causes duplicate touch operations of same metatile file Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant