Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Restore metric logging to third-party loggers in Benchmarking Pipeline #2056

Open
ashwinvaidya17 opened this issue May 14, 2024 · 2 comments · May be fixed by #2489
Open

[Task]: Restore metric logging to third-party loggers in Benchmarking Pipeline #2056

ashwinvaidya17 opened this issue May 14, 2024 · 2 comments · May be fixed by #2489
Labels
Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute.

Comments

@ashwinvaidya17
Copy link
Collaborator

What is the motivation for this task?

The current version of benchmarking does not support logging the metrics to third-party loggers like (tensorboard, comet, wandb)

Describe the solution you'd like

A quite simple fix would be to add the dictionary of metrics to the logger in the save method of the job.

Note to implementer: Ensure that all logger parameters are configurable to avoid issues due to hard-coding #1437

Additional context

No response

@ashwinvaidya17 ashwinvaidya17 added the Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. label May 14, 2024
@zhaozzt
Copy link

zhaozzt commented Jun 11, 2024

Please teach me how to modify the code

@AdityaSinghDevs
Copy link

Hey @ashwinvaidya17 , I noticed this issue is currently unassigned. If it’s still available, I would be interested in working on it. Please let me know if I can assist with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants