[WC] Fix ratio_defining_params #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF OpenVINO
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2653 +/- ##
============================================
- Coverage 62.02% 29.87% -32.16%
============================================
Files 495 495
Lines 45973 45971 -2
============================================
- Hits 28516 13735 -14781
- Misses 17457 32236 +14779
... and 264 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ljaljushkin
requested changes
Apr 25, 2024
ljaljushkin
reviewed
Apr 25, 2024
| ratio_defining_params = list( | ||
| filter( | ||
| lambda wp: wp.node_with_weight.metatype in self._backend_entity.matmul_metatypes, | ||
| all_weight_params, | ||
| ) | ||
| ) | ||
|
|
||
| # The last MatMul layer is quantized to 4-bits if all_layers=True or if the layer is shared |
There was a problem hiding this comment.
This comment looks wrong.
if the layer is shared means that it has the same precision as embedding, and it's 4bit only with all_layers
ljaljushkin
approved these changes
Apr 25, 2024
l-bat
force-pushed
the
lt/fix_ratio_defining_params
branch
from
bbc7f71 to
15afc14
Compare
ljaljushkin
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
Fix bug in
_get_ratio_defining_paramsmethodTests
test_shared_gather_all_layers