Whisper pipeline: use Sampler #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: continuous batching
ilya-lavrenov
approved these changes
Jan 23, 2025
Wovchena
approved these changes
Jan 24, 2025
| } | ||
| } | ||
|
|
||
| std::pair<ov::genai::EncodedResults, bool> decode(std::shared_ptr<ov::genai::WhisperDecoder> decoder, |
There was a problem hiding this comment.
Suggested change
| std::pair<ov::genai::EncodedResults, bool> decode(std::shared_ptr<ov::genai::WhisperDecoder> decoder, | |
| std::pair<ov::genai::EncodedResults, bool> decode(const std::shared_ptr<ov::genai::WhisperDecoder>& decoder, |
| const ov::Tensor& encoder_hidden_state, | ||
| const std::shared_ptr<ov::genai::StreamerBase> streamer_ptr, | ||
| ov::genai::Sampler& sampler, | ||
| ov::genai::SequenceGroup::Ptr sequence_group, |
There was a problem hiding this comment.
Suggested change
| ov::genai::SequenceGroup::Ptr sequence_group, | |
| const ov::genai::SequenceGroup::Ptr& sequence_group, |
| const float* logits_data = logits.data<const float>() + batch_offset + sequence_offset; | ||
|
|
||
| int64_t out_token = std::max_element(logits_data, logits_data + vocab_size) - logits_data; | ||
| float max_logit = logits_data[out_token]; |
There was a problem hiding this comment.
Suggested change
| float max_logit = logits_data[out_token]; |
Not used
| top_p: if set to float < 1, only the smallest set of most probable tokens with probabilities that add up to top_p or higher are kept for generation. | ||
| top_k: the number of highest probability vocabulary tokens to keep for top-k-filtering. | ||
| do_sample: whether or not to use multinomial random sampling that add up to `top_p` or higher are kept. | ||
| num_return_sequences: the number of sequences to generate from a single prompt. |
There was a problem hiding this comment.
rng_seed is missing. Although it's not Whisper's fault because it's missing in the parent config as well. Can you add it, possible in a separate PR
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: 152889
Closes #1164