Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should probably by 'intersects' rather than 'bboverlaps' #157

Open
joshuamaxwell opened this issue Feb 5, 2018 · 2 comments
Open

Should probably by 'intersects' rather than 'bboverlaps' #157

joshuamaxwell opened this issue Feb 5, 2018 · 2 comments

Comments

@joshuamaxwell
Copy link

https://github.com/djangonauts/django-rest-framework-gis/blob/8febe79fb8291f20b8f6e9c53ac8db8a24ceb26e/rest_framework_gis/filters.py#L65

The bboverlaps comparison will only return geometries whose boundaries cross over the bbox but it WILL NOT return any geometries that are wholly contained within the bbox (at least not for mySQL/mariaDB)
@nemesifier
Copy link
Member

Changing the behaviour may lead to unwanted behaviour in applications that depend on this library.

Maybe the best path is to document this properly and add also the possibility to use the other filter.

@nemesifier
Copy link
Member

@joshuamaxwell do you have any suggestion regarding this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemesifier @joshuamaxwell