USE_CLANG does not get set in crosstool_wrapper_driver_rocm.tpl

[davidheiss]

I encountered a build error when building JAX for ROCm.
It seemed like the 'compiler' template value don't get set, causing an unknown compiler flag for clang.

Might have something to do with recent changes in #19691 #19767.

# Template values set by rocm_configure.bzl.
CPU_COMPILER = ('%{cpu_compiler}')
USE_CLANG = ('%{compiler}' == 'clang')
HOST_COMPILER_PATH = ('%{host_compiler_path}')

https://github.com/openxla/xla/blob/e52f275aba0ba1cf9573df906b14d8f3bcedf8c6/third_party/tsl/third_party/gpus/crosstool/clang/bin/crosstool_wrapper_driver_rocm.tpl#L27C1-L27C39

[davidheiss]

For me removing this lines from the template resolves the issue.

  if not USE_CLANG:
      cpu_compiler_flags.append('-fno-canonical-system-headers')

https://github.com/openxla/xla/blob/e52f275aba0ba1cf9573df906b14d8f3bcedf8c6/third_party/tsl/third_party/gpus/crosstool/clang/bin/crosstool_wrapper_driver_rocm.tpl#L267C1-L267C65

[davidheiss]

The build command for JAX (release/0.4.38) was this one:

python ./build/build.py build --wheels=jaxlib,jax-rocm-plugin,jax-rocm-pjrt --rocm_version=60 --rocm_path=/opt/rocm --clang_path=/opt/rocm/llvm/bin/clang

[akuegel]

@draganmladjenovic can you maybe route this to someone from AMD, or look into it yourself?