Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java 21 java -jar zipkin.jar #3694

Closed
jinyulei0710 opened this issue Jan 17, 2024 · 7 comments · Fixed by #3696
Closed

java 21 java -jar zipkin.jar #3694

jinyulei0710 opened this issue Jan 17, 2024 · 7 comments · Fixed by #3696
Labels

Comments

@jinyulei0710
Copy link

Describe the Bug

java.lang.IllegalArgumentException: Unsupported URL: jar:nested:/root/zipkin.jar/!BOOT-INF/lib/zipkin-lens-3.0.3.jar!/zipkin-lens/static/js/main.d21e7047.js (must start with 'file:', 'jar:file', 'jrt:' or 'bundle:').
And the ui load error.

Steps to Reproduce

curl -sSL https://zipkin.io/quickstart.sh | bash -s
java -jar zipkin.jar

java -version
openjdk version "21.0.1" 2023-10-17 LTS
OpenJDK Runtime Environment Corretto-21.0.1.12.1 (build 21.0.1+12-LTS)
OpenJDK 64-Bit Server VM Corretto-21.0.1.12.1 (build 21.0.1+12-LTS, mixed mode, sharing)

Expected Behaviour

ui showed

@codefromthecrypt
Copy link
Member

looking, thanks

@codefromthecrypt
Copy link
Member

opened line/armeria#5390 while try to think about a workaround..

@codefromthecrypt
Copy link
Member

patching HttpFile to pass on the path starting with "nested" works, but adding a patched file from Armeria is a NOTICE pain, because it is not a file we wrote.. cc @openzipkin/armeria I'll try to find another way, but all the classes we couldl work around this with seem package protected. At the moment zipkin is toast over this

@codefromthecrypt
Copy link
Member

line/armeria#5391 should fix this but we need to figure out if we can wait for the release. since the project is busted, probably we need a temporary workaround.

@codefromthecrypt
Copy link
Member

once #3696 lands I'll release and raise a patch to homebrew also

@codefromthecrypt
Copy link
Member

verified back to working in 3.0.4

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Jan 17, 2024

Homebrew/homebrew-core#160208 for homebrew update (brew bump-formula-pr zipkin --version 3.0.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants