-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Bazel BUILD file names post-Gradle #1532
Comments
I've decided to start questioning whether we actually want this. bazelbuild/bazel#4517 has some excellent discussion on the matter. While it doesn't result in an actual decision, it seems that there are more pros to keeping the '.bazel' extension than to remove it:
While I did make the effort to rename BUILD files in #5652, I actually think I'm going to undo that change and instead remove the TODOs (with an explanation as to why). It seems better to keep the Edit: I would like to document the only cons I can think of, as well, to be thorough in this discussion:
|
Is your feature request related to a problem? Please describe.
Bazel convention suggests that all Bazel BUILD files should be named
BUILD
. However, as we gradually move to Bazel while still building with Gradle, using this convention cause naming conflicts with existing Gradle files. Thus, all Bazel BUILD files are namedBUILD.bazel
. Although this is still acceptable to Bazel, it is not proper convention and should not be used post-Gradle in Oppia Android.Describe the solution you'd like
Once Oppia Android has been moved off of Gradle and is building completely with Bazel, we should refactor all Bazel build files to be named
BUILD
instead ofBUILD.bazel
The text was updated successfully, but these errors were encountered: