Fabric API (1.20.2) conflicts with ViaBackwards #3391

Kichura · 2023-10-24T21:12:30Z

Kichura
Oct 24, 2023

Minecraft Logs

[kichura@velocity fabric]$ java -jar fabric-server-launch.jar nogui
Unpacking 1.20.2/server-1.20.2.jar (versions:1.20.2) to versions/1.20.2/server-1.20.2.jar
Unpacking com/github/oshi/oshi-core/6.4.5/oshi-core-6.4.5.jar (libraries:com.github.oshi:oshi-core:6.4.5) to libraries/com/github/oshi/oshi-core/6.4.5/oshi-core-6.4.5.jar
Unpacking com/google/code/gson/gson/2.10.1/gson-2.10.1.jar (libraries:com.google.code.gson:gson:2.10.1) to libraries/com/google/code/gson/gson/2.10.1/gson-2.10.1.jar
Unpacking com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar (libraries:com.google.guava:failureaccess:1.0.1) to libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar
Unpacking com/google/guava/guava/32.1.2-jre/guava-32.1.2-jre.jar (libraries:com.google.guava:guava:32.1.2-jre) to libraries/com/google/guava/guava/32.1.2-jre/guava-32.1.2-jre.jar
Unpacking com/mojang/authlib/5.0.47/authlib-5.0.47.jar (libraries:com.mojang:authlib:5.0.47) to libraries/com/mojang/authlib/5.0.47/authlib-5.0.47.jar
Unpacking com/mojang/brigadier/1.1.8/brigadier-1.1.8.jar (libraries:com.mojang:brigadier:1.1.8) to libraries/com/mojang/brigadier/1.1.8/brigadier-1.1.8.jar
Unpacking com/mojang/datafixerupper/6.0.8/datafixerupper-6.0.8.jar (libraries:com.mojang:datafixerupper:6.0.8) to libraries/com/mojang/datafixerupper/6.0.8/datafixerupper-6.0.8.jar
Unpacking com/mojang/logging/1.1.1/logging-1.1.1.jar (libraries:com.mojang:logging:1.1.1) to libraries/com/mojang/logging/1.1.1/logging-1.1.1.jar
Unpacking commons-io/commons-io/2.13.0/commons-io-2.13.0.jar (libraries:commons-io:commons-io:2.13.0) to libraries/commons-io/commons-io/2.13.0/commons-io-2.13.0.jar
Unpacking io/netty/netty-buffer/4.1.97.Final/netty-buffer-4.1.97.Final.jar (libraries:io.netty:netty-buffer:4.1.97.Final) to libraries/io/netty/netty-buffer/4.1.97.Final/netty-buffer-4.1.97.Final.jar
Unpacking io/netty/netty-codec/4.1.97.Final/netty-codec-4.1.97.Final.jar (libraries:io.netty:netty-codec:4.1.97.Final) to libraries/io/netty/netty-codec/4.1.97.Final/netty-codec-4.1.97.Final.jar
Unpacking io/netty/netty-common/4.1.97.Final/netty-common-4.1.97.Final.jar (libraries:io.netty:netty-common:4.1.97.Final) to libraries/io/netty/netty-common/4.1.97.Final/netty-common-4.1.97.Final.jar
Unpacking io/netty/netty-handler/4.1.97.Final/netty-handler-4.1.97.Final.jar (libraries:io.netty:netty-handler:4.1.97.Final) to libraries/io/netty/netty-handler/4.1.97.Final/netty-handler-4.1.97.Final.jar
Unpacking io/netty/netty-resolver/4.1.97.Final/netty-resolver-4.1.97.Final.jar (libraries:io.netty:netty-resolver:4.1.97.Final) to libraries/io/netty/netty-resolver/4.1.97.Final/netty-resolver-4.1.97.Final.jar
Unpacking io/netty/netty-transport/4.1.97.Final/netty-transport-4.1.97.Final.jar (libraries:io.netty:netty-transport:4.1.97.Final) to libraries/io/netty/netty-transport/4.1.97.Final/netty-transport-4.1.97.Final.jar
Unpacking io/netty/netty-transport-classes-epoll/4.1.97.Final/netty-transport-classes-epoll-4.1.97.Final.jar (libraries:io.netty:netty-transport-classes-epoll:4.1.97.Final) to libraries/io/netty/netty-transport-classes-epoll/4.1.97.Final/netty-transport-classes-epoll-4.1.97.Final.jar
Unpacking io/netty/netty-transport-native-epoll/4.1.97.Final/netty-transport-native-epoll-4.1.97.Final-linux-x86_64.jar (libraries:io.netty:netty-transport-native-epoll:4.1.97.Final:linux-x86_64) to libraries/io/netty/netty-transport-native-epoll/4.1.97.Final/netty-transport-native-epoll-4.1.97.Final-linux-x86_64.jar
Unpacking io/netty/netty-transport-native-epoll/4.1.97.Final/netty-transport-native-epoll-4.1.97.Final-linux-aarch_64.jar (libraries:io.netty:netty-transport-native-epoll:4.1.97.Final:linux-aarch_64) to libraries/io/netty/netty-transport-native-epoll/4.1.97.Final/netty-transport-native-epoll-4.1.97.Final-linux-aarch_64.jar
Unpacking io/netty/netty-transport-native-unix-common/4.1.97.Final/netty-transport-native-unix-common-4.1.97.Final.jar (libraries:io.netty:netty-transport-native-unix-common:4.1.97.Final) to libraries/io/netty/netty-transport-native-unix-common/4.1.97.Final/netty-transport-native-unix-common-4.1.97.Final.jar
Unpacking it/unimi/dsi/fastutil/8.5.12/fastutil-8.5.12.jar (libraries:it.unimi.dsi:fastutil:8.5.12) to libraries/it/unimi/dsi/fastutil/8.5.12/fastutil-8.5.12.jar
Unpacking net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar (libraries:net.java.dev.jna:jna:5.13.0) to libraries/net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar
Unpacking net/java/dev/jna/jna-platform/5.13.0/jna-platform-5.13.0.jar (libraries:net.java.dev.jna:jna-platform:5.13.0) to libraries/net/java/dev/jna/jna-platform/5.13.0/jna-platform-5.13.0.jar
Unpacking net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar (libraries:net.sf.jopt-simple:jopt-simple:5.0.4) to libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar
Unpacking org/apache/commons/commons-lang3/3.13.0/commons-lang3-3.13.0.jar (libraries:org.apache.commons:commons-lang3:3.13.0) to libraries/org/apache/commons/commons-lang3/3.13.0/commons-lang3-3.13.0.jar
Unpacking org/apache/logging/log4j/log4j-api/2.19.0/log4j-api-2.19.0.jar (libraries:org.apache.logging.log4j:log4j-api:2.19.0) to libraries/org/apache/logging/log4j/log4j-api/2.19.0/log4j-api-2.19.0.jar
Unpacking org/apache/logging/log4j/log4j-core/2.19.0/log4j-core-2.19.0.jar (libraries:org.apache.logging.log4j:log4j-core:2.19.0) to libraries/org/apache/logging/log4j/log4j-core/2.19.0/log4j-core-2.19.0.jar
Unpacking org/apache/logging/log4j/log4j-slf4j2-impl/2.19.0/log4j-slf4j2-impl-2.19.0.jar (libraries:org.apache.logging.log4j:log4j-slf4j2-impl:2.19.0) to libraries/org/apache/logging/log4j/log4j-slf4j2-impl/2.19.0/log4j-slf4j2-impl-2.19.0.jar
Unpacking org/joml/joml/1.10.5/joml-1.10.5.jar (libraries:org.joml:joml:1.10.5) to libraries/org/joml/joml/1.10.5/joml-1.10.5.jar
Unpacking org/slf4j/slf4j-api/2.0.7/slf4j-api-2.0.7.jar (libraries:org.slf4j:slf4j-api:2.0.7) to libraries/org/slf4j/slf4j-api/2.0.7/slf4j-api-2.0.7.jar
Starting net.fabricmc.loader.impl.game.minecraft.BundlerClassPathCapture
[23:03:12] [main/INFO]: Loading Minecraft 1.20.2 with Fabric Loader 0.14.24
[23:03:12] [main/INFO]: Fabric is preparing JARs on first launch, this may take a few seconds...
[23:03:12] [main/INFO]: Loading 58 mods:
        - fabric-api 0.90.4+1.20.2
           |-- fabric-api-base 0.4.33+fce67b32a0
           |-- fabric-api-lookup-api-v1 1.6.42+b1792f7da0
           |-- fabric-biome-api-v1 13.0.14+b1792f7da0
           |-- fabric-block-api-v1 1.0.12+73761d2ea0
           |-- fabric-block-view-api-v2 1.0.1+73761d2ea0
           |-- fabric-blockrenderlayer-v1 1.1.43+f4b7e424a0
           |-- fabric-client-tags-api-v1 1.1.4+86b12645a0
           |-- fabric-command-api-v1 1.2.37+f71b366fa0
           |-- fabric-command-api-v2 2.2.16+b1792f7da0
           |-- fabric-commands-v0 0.2.54+df3654b3a0
           |-- fabric-containers-v0 0.1.74+df3654b3a0
           |-- fabric-content-registries-v0 5.0.5+b1792f7da0
           |-- fabric-convention-tags-v1 1.5.8+b1792f7da0
           |-- fabric-crash-report-info-v1 0.2.20+f4b7e424a0
           |-- fabric-data-generation-api-v1 13.1.4+b1792f7da0
           |-- fabric-dimensions-v1 2.1.57+b1792f7da0
           |-- fabric-entity-events-v1 1.5.26+b1792f7da0
           |-- fabric-events-interaction-v0 0.6.10+b1792f7da0
           |-- fabric-events-lifecycle-v0 0.2.69+df3654b3a0
           |-- fabric-game-rule-api-v1 1.0.41+b1792f7da0
           |-- fabric-item-api-v1 2.1.33+b1792f7da0
           |-- fabric-item-group-api-v1 4.0.15+e3d2bf3fa0
           |-- fabric-key-binding-api-v1 1.0.38+f4b7e424a0
           |-- fabric-keybindings-v0 0.2.36+df3654b3a0
           |-- fabric-language-kotlin 1.10.10+kotlin.1.9.10
           |    |-- org_jetbrains_kotlin_kotlin-reflect 1.9.10
           |    |-- org_jetbrains_kotlin_kotlin-stdlib 1.9.10
           |    |-- org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.9.10
           |    |-- org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.9.10
           |    |-- org_jetbrains_kotlinx_atomicfu-jvm 0.22.0
           |    |-- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.7.3
           |    |-- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.7.3
           |    |-- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.4.0
           |    |-- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.6.0
           |    |-- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.6.0
           |    \-- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.6.0
           |-- fabric-lifecycle-events-v1 2.2.27+b1792f7da0
           |-- fabric-loot-api-v2 2.1.1+3ba460fba0
           |-- fabric-message-api-v1 6.0.2+e3d2bf3fa0
           |-- fabric-mining-level-api-v1 2.1.55+f4b7e424a0
           |-- fabric-model-loading-api-v1 1.0.6+b1792f7da0
           |-- fabric-models-v0 0.4.5+9386d8a7a0
           |-- fabric-networking-api-v1 3.0.10+b1792f7da0
           |-- fabric-object-builder-api-v1 12.1.2+2ff98d3ba0
           |-- fabric-particles-v1 1.1.4+f4b7e424a0
           |-- fabric-recipe-api-v1 2.0.7+b1792f7da0
           |-- fabric-registry-sync-v0 4.0.5+b1792f7da0
           |-- fabric-renderer-api-v1 3.2.1+2034447ca0
           |-- fabric-renderer-indigo 1.5.1+2034447ca0
           |-- fabric-renderer-registries-v1 3.2.49+df3654b3a0
           |-- fabric-rendering-data-attachment-v1 0.3.39+73761d2ea0
           |-- fabric-rendering-fluids-v1 3.0.30+f4b7e424a0
           |-- fabric-rendering-v0 1.1.52+df3654b3a0
           |-- fabric-rendering-v1 3.0.11+b1792f7da0
           |-- fabric-resource-conditions-api-v1 2.3.10+e3d2bf3fa0
           |-- fabric-resource-loader-v0 0.11.12+b1792f7da0
           |-- fabric-screen-api-v1 2.0.12+b1792f7da0
           |-- fabric-screen-handler-api-v1 1.3.40+b1792f7da0
           |-- fabric-sound-api-v1 1.0.14+f4b7e424a0
           |-- fabric-transfer-api-v1 3.3.9+b1792f7da0
           \-- fabric-transitive-access-wideners-v1 5.0.3+fce67b32a0
        - fabricloader 0.14.24
        - java 17
        - minecraft 1.20.2
        - viabackwards 4.9.0-23w42a-SNAPSHOT
        - viafabric 0.4.11+447-dev
           |-- cotton-client-commands 1.1.0+1.15.2
           |-- org_yaml_snakeyaml 2.2
           |-- viafabric-mc120 0.4.11+447-dev
           \-- viaversion 4.9.0-23w42a-SNAPSHOT
        - viarewind 3.0.3-SNAPSHOT
[23:03:12] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/home/kichura/Downloads/fabric/libraries/net/fabricmc/sponge-mixin/0.12.5+mixin.0.8.5/sponge-mixin-0.12.5+mixin.0.8.5.jar Service=Knot/Fabric Env=SERVER
[23:03:12] [main/INFO]: Compatibility level set to JAVA_16
[23:03:12] [main/INFO]: Compatibility level set to JAVA_17
[23:03:17] [Via-Mappingloader-0/INFO]: Loading block connection mappings ...
[23:03:17] [Via-Mappingloader-0/INFO]: Using FastUtil Long2ObjectOpenHashMap for block connections
[23:03:17] [main/INFO]: Loading translations...
[23:03:17] [main/INFO]: Registering protocols...
[23:03:17] [main/INFO]: ViaVersion detected server version: 1.20.2 (764)
[23:03:17] [ViaFabric-2/INFO]: Finished mapping loading, shutting down loader executor!
[23:03:18] [main/INFO]: Environment: Environment[accountsHost=https://api.mojang.com, sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD]
[23:03:18] [ViaFabric-0/WARN]: You are running a newer version of the plugin than is released!
[23:03:19] [main/INFO]: Loaded 7 recipes
[23:03:19] [main/INFO]: Loaded 1271 advancements
[23:03:19] [main/INFO]: Applied 0 biome modifications to 0 of 64 new biomes in 1.447 ms
[23:03:19] [Server thread/INFO]: Starting minecraft server version 1.20.2
[23:03:19] [Server thread/INFO]: Loading properties
[23:03:19] [Server thread/INFO]: Default game type: SURVIVAL
[23:03:19] [Server thread/INFO]: Generating keypair
[23:03:19] [Server thread/INFO]: Starting Minecraft server on *:25565
[23:03:19] [Server thread/INFO]: Using epoll channel type
[23:03:19] [Server thread/INFO]: Preparing level "world"
[23:03:22] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[23:03:22] [Worker-Main-10/INFO]: Preparing spawn area: 0%
[23:03:23] [Worker-Main-8/INFO]: Preparing spawn area: 0%
[23:03:23] [Worker-Main-2/INFO]: Preparing spawn area: 0%
[23:03:24] [Worker-Main-5/INFO]: Preparing spawn area: 4%
[23:03:24] [Worker-Main-12/INFO]: Preparing spawn area: 7%
[23:03:25] [Worker-Main-1/INFO]: Preparing spawn area: 11%
[23:03:25] [Worker-Main-14/INFO]: Preparing spawn area: 16%
[23:03:26] [Worker-Main-10/INFO]: Preparing spawn area: 22%
[23:03:26] [Worker-Main-7/INFO]: Preparing spawn area: 26%
[23:03:27] [Worker-Main-3/INFO]: Preparing spawn area: 33%
[23:03:27] [Worker-Main-6/INFO]: Preparing spawn area: 39%
[23:03:28] [Worker-Main-7/INFO]: Preparing spawn area: 45%
[23:03:28] [Worker-Main-2/INFO]: Preparing spawn area: 52%
[23:03:29] [Worker-Main-1/INFO]: Preparing spawn area: 59%
[23:03:29] [Worker-Main-2/INFO]: Preparing spawn area: 68%
[23:03:30] [Worker-Main-3/INFO]: Preparing spawn area: 74%
[23:03:30] [Worker-Main-12/INFO]: Preparing spawn area: 83%
[23:03:31] [Worker-Main-10/INFO]: Preparing spawn area: 90%
[23:03:31] [Worker-Main-5/INFO]: Preparing spawn area: 97%
[23:03:31] [Server thread/INFO]: Time elapsed: 9093 ms
[23:03:31] [Server thread/INFO]: Done (11.953s)! For help, type "help"
[23:03:52] [User Authenticator #1/INFO]: UUID of player Mesa3D is 618a8390-51b1-43b2-a53a-ab72c1bbd8bd
[23:03:53] [Server thread/INFO]: com.mojang.authlib.GameProfile@2ccb7078[id=618a8390-51b1-43b2-a53a-ab72c1bbd8bd,name=Mesa3D,properties={textures=[Property[name=textures, value=ewogICJ0aW1lc3RhbXAiIDogMTY5ODE4MTQzMjY2NCwKICAicHJvZmlsZUlkIiA6ICI2MThhODM5MDUxYjE0M2IyYTUzYWFiNzJjMWJiZDhiZCIsCiAgInByb2ZpbGVOYW1lIiA6ICJNZXNhM0QiLAogICJzaWduYXR1cmVSZXF1aXJlZCIgOiB0cnVlLAogICJ0ZXh0dXJlcyIgOiB7CiAgICAiU0tJTiIgOiB7CiAgICAgICJ1cmwiIDogImh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvOTAyNWQ2NWMyNmY5ZTlmNWNjYzgxODBkZDZlNjE2YmNmZjRhNmRmZTc4ODY4MGFlNjZlYWExYjdmMDAyMmFjYiIsCiAgICAgICJtZXRhZGF0YSIgOiB7CiAgICAgICAgIm1vZGVsIiA6ICJzbGltIgogICAgICB9CiAgICB9CiAgfQp9, signature=wKfaHkBnjLq0BsEkCcqMyXoJ3YPBHuYo9FwLCmSCnPDnMka4R/Ma+S6pA5mYBlEBD324G1uq2hxP/kaq2A50WIiJ+pC6iV7qWGmuK/wRqnsqQBmkMLw8JdzvJWevtpkbbb6KQZJnJ8oeDUhiGI6sH4ZqTZvQpc97bzXFUn9u+CPzZ4jQTO4NiuyYlvNtIDm0BJqyDOhcv27dLBkRzcLcdlt6BzwhRiMH/KrIl40scwG949JR9NM2aSOznKQ3DmBY5ibPHPqhSnmmJ0lV5PT/Gq0jTG3uaqvyXFqJJAwTiIJG8mvtrxqeYIQjXTTXp1oJ+Ura/a1XNKyAA0B0uGjzQgu+zAZ59yaqB9dF2yUEbDTYKP09jyhWwzDO7YHmGCKsnz/S2PPVtc9fiVReHbtAvDj2eoxTC7N4ObrN45lJNyQAJ5XmvbWQdWxE+k86y+1qTvgehOcyogxTu3SevKlgdBljc+sO0GHpFKt6fkaPKgI2+jb2/NF4pdMxY8m/m0qRsGJ3VFvuLaH/DPc9B3mkPxD840b4+n98SaLaItp5l08jV3uc+uZYazDnu0oKzZsloY1irlieGblMN4y054lnF8HAgHU8delWBuj8EcmoPOC0R1uV7WY9iy2CxKWs1EMe99GjfMpcXJyI39ZPOY5BuUeu7cWagjuPzqNhabSJq+k=]]}] lost connection: Disconnected

Description

When attempting to use latest viafabric with latest viabackwards on a 1.20.2 server, the mods work as intended in terms of compatibility support but when Fabric API is included onto the server - it will cause disconnect gibberish to occur in server console itself as seen in minecraft logs along with a netty decoding exception, I have asked the viaversion devs about this issue and they cannot seem to do anything about it hence i redirected my issue here to see if Fabric API can try to solve it instead.

Also another thing i wanna answer is that i cannot seem to reproduce this problem on 1.19.4 and older fabric servers whatsoever, therefore i wanna know if #3324 is at fault or another change in API caused this problem to occur in first place?

Answered by FlorianMichael

Nov 30, 2023

This issue has been fixed in latest VIaBackwards and can be closed now.

View full answer

apple502j · 2023-10-25T01:38:47Z

apple502j
Oct 25, 2023
Collaborator

Apparently Velocity still lacks support for Fabric 1.20.2.
PaperMC/Velocity#1096

10 replies

Linguardium Oct 30, 2023

I dont believe the "me too me too" is adding to the conversation any. is there any additional information you are providing to the issue here?

a different config? new findings?

Kichura Oct 30, 2023
Author

I believe the reason why people are saying "me too" over and over is because they are able to reproduce it themselves aswell when in reality all it does is create more and more spam at this point.

Linguardium Oct 30, 2023

yeah, its a known issue at this point and has been. 1.20.2 is still not fully supported by viabackwards and issues are still being worked on. if the issue has not been opened up there, it should be.

VainAsher Oct 30, 2023

sorry i am new to this. i commented to flag for updates, and to stress that its a fabric issue not paper/velocity as i am not using those proxies. i am quite new to all this and the learning curve is steep...

SyedOmarNoor Nov 12, 2023

any updates? this is annoying

Linguardium · 2023-10-30T22:36:41Z

Linguardium
Oct 30, 2023

if anyone else wants to subscribe to notifications, there is a button on the right side at the top that will Subscribe to the discussion. be sure to check ViaBackward's issue tracker and report the issue if it has not been reported.

0 replies

isjerryxiao · 2023-11-15T13:42:39Z

isjerryxiao
Nov 15, 2023

Fabric api on the server is using a packet https://wiki.vg/Protocol#Ping_.28configuration.29 which is never used by the Notchian server, therefore is not implemented by viabackwards.

fabric/fabric-networking-api-v1/src/main/java/net/fabricmc/fabric/impl/networking/server/ServerConfigurationNetworkAddon.java

Line 72 in 65c120e

this.sendPacket(new CommonPingS2CPacket(0xFAB71C));

However even when implemented as below the client would still be stuck joining forever for some unknown reason, probably due to timing error of the packets transmitted back to the server by viabackwards.

diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java b/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
index 7b3cef96..ea042160 100644
--- a/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
+++ b/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
@@ -118,6 +118,14 @@ public final class Protocol1_20To1_20_2 extends BackwardsProtocol<ClientboundPac
         registerClientbound(State.CONFIGURATION, ClientboundConfigurationPackets1_20_2.KEEP_ALIVE.getId(), -1, wrapper -> {
             wrapper.setPacketType(ClientboundPackets1_19_4.KEEP_ALIVE);
         });
+        registerClientbound(State.CONFIGURATION, ClientboundConfigurationPackets1_20_2.PING.getId(), -1, wrapper -> {
+            wrapper.cancel();
+
+            final int packetId = wrapper.read(Type.INT);
+            final PacketWrapper pingResponse = wrapper.create(ServerboundConfigurationPackets1_20_2.PONG);
+            pingResponse.write(Type.INT, packetId);
+            pingResponse.sendToServer(Protocol1_20To1_20_2.class);
+        });
         registerClientbound(State.CONFIGURATION, ClientboundConfigurationPackets1_20_2.RESOURCE_PACK.getId(), -1, wrapper -> {
             // Send after join. We have to pretend the client accepted, else the server won't continue...
             wrapper.user().get(ConfigurationPacketStorage.class).setResourcePack(wrapper);

After some pcaping & trial and error I wrote a dirty hack that works for fabric servers but can hardy be called a patch.

diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java b/common/src/main/java/com/viaversion/vi
abackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
index 7b3cef96..6688f84e 100644
--- a/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
+++ b/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
@@ -79,7 +79,12 @@ public final class Protocol1_20To1_20_2 extends BackwardsProtocol<ClientboundPac
 
             // States set to configuration in the base protocol
             wrapper.create(ServerboundLoginPackets.LOGIN_ACKNOWLEDGED).sendToServer(Protocol1_20To1_20_2.class);
+
+            final PacketWrapper pingResponse = wrapper.create(ServerboundConfigurationPackets1_20_2.PONG);
+            pingResponse.write(Type.INT, 0xFAB71C);
+            pingResponse.sendToServer(Protocol1_20To1_20_2.class);
         });
+        cancelClientbound(State.CONFIGURATION, ClientboundConfigurationPackets1_20_2.PING.getId());
 
         registerClientbound(State.CONFIGURATION, ClientboundConfigurationPackets1_20_2.FINISH_CONFIGURATION.getId(), ClientboundConfigurationPackets1_20_2.FI
NISH_CONFIGURATION.getId(), wrapper -> {
             wrapper.cancel();

Then ALL motivation to investigate further is lost for me.
Looking forward for your findings.

6 replies

modmuss50 Nov 15, 2023
Maintainer

Fabric api on the server is using a packet https://wiki.vg/Protocol#Ping_.28configuration.29 which is never used by the Notchian server

The vanilla client will respond to this packet. Im not familar with how viabackwards works but it should be fine for us to send this packet during configuration?

isjerryxiao Nov 15, 2023

Sending this packet is fine, however it's out of the vanilla behavior so viabackwards didn't implement it (which means a direct byte-to-byte pass-through), causing 1.20 clients to interpret this ping s2c packet as other packets. The real problem is after fixing viabackwards to return a ping c2s response there's still something wrong preventing the brand new 1.20.2 CONFIGURING phase thing from finishing properly. Maybe running ViaAAS and do a two way pcap would help.

Kichura Nov 15, 2023
Author

Using viafabric in client-side mode actually works fine but using it on server-side is where the problem begins to happen. (spigot/paper servers with viaversion on it works properly however)

isjerryxiao Nov 16, 2023

I don't think so, there is no way client side viafabric on minecraft 1.20 / 1.20.1 translates 1.20.2 protocol properly. You must have been using a 1.20.2 client in which case viabackwards is pointless.

Kichura Nov 16, 2023
Author

Well this one is correct although i mostly referred to 1.19.4 and older where viabackwards is required which in this case does work as intended, the unsupported 1.20.1 client-side however isn't supported.

FlorianMichael · 2023-11-30T17:58:31Z

FlorianMichael
Nov 30, 2023

This issue has been fixed in latest VIaBackwards and can be closed now.

0 replies

isjerryxiao · 2023-12-20T03:47:06Z

isjerryxiao
Dec 20, 2023

@FlorianMichael The connection still hangs with the proposed fix and this is what I have to do in order to get it working.

diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java b/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
index 3a64d92e..289f269f 100644
--- a/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
+++ b/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/Protocol1_20To1_20_2.java
@@ -119,7 +119,9 @@ public final class Protocol1_20To1_20_2 extends BackwardsProtocol<ClientboundPac
             wrapper.setPacketType(ClientboundPackets1_19_4.KEEP_ALIVE);
         });
         registerClientbound(State.CONFIGURATION, ClientboundConfigurationPackets1_20_2.PING.getId(), -1, wrapper -> {
-            wrapper.setPacketType(ClientboundPackets1_19_4.PING);
+            final PacketWrapper pingResponse = wrapper.create(ServerboundConfigurationPackets1_20_2.PONG);
+            pingResponse.write(Type.INT, wrapper.read(Type.INT));
+            pingResponse.scheduleSendToServer(Protocol1_20To1_20_2.class);
         });
         registerClientbound(State.CONFIGURATION, ClientboundConfigurationPackets1_20_2.RESOURCE_PACK.getId(), -1, wrapper -> {
             // Send after join. We have to pretend the client accepted, else the server won't continue...

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FabricMC

Fabric API (1.20.2) conflicts with ViaBackwards #3391

{{title}}

Replies: 5 comments 16 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

Fabric API (1.20.2) conflicts with ViaBackwards #3391

Minecraft Logs

Description

Replies: 5 comments · 16 replies

apple502j Oct 25, 2023 Collaborator

Kichura Oct 30, 2023 Author

modmuss50 Nov 15, 2023 Maintainer

Kichura Nov 15, 2023 Author

Kichura Nov 16, 2023 Author

Replies: 5 comments 16 replies

apple502j
Oct 25, 2023
Collaborator

Kichura Oct 30, 2023
Author

modmuss50 Nov 15, 2023
Maintainer

Kichura Nov 15, 2023
Author

Kichura Nov 16, 2023
Author