-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Cannot create new files with Append mode #3358
Comments
franzpoeschel
added a commit
to franzpoeschel/openPMD-api
that referenced
this issue
Oct 4, 2022
ax3l
added a commit
to openPMD/openPMD-api
that referenced
this issue
Oct 7, 2022
* Add failing test * Allow creating file-based Series with Append mode even if the specified directory does not exist * Add Mpi.hpp with MPI helpers Needed later for checking file presence in parallel situations * Add CHECK_FILE IO task and implement in the backends * Only write top-level attributes when really needed * Enable Series creation in Append mode * Add Windows CI workaround * Windows Workaround: Fallback to Create mode * Avoid MPI mocking, use ifdefs Also use parallel logical or for file existence check * Append mode: test in parallel * Don't alias sendbfr and recvbfr * Undo unused changes * Remove unused Mock_MPI_Comm * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replace MPI specializations by if constexpr * Try making this constexpr I think that this won't work with every MPI implementation * Link ADIOS2 issue ornladios/ADIOS2#3358 Co-authored-by: Axel Huebl <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Catching and printing the error:
@pnorbert suggested adding As we have a workaround for this in our implementation, this is not really critical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On Linux, the Append mode can be used to create new files. On Windows, the program aborts if the file does not yet exist.
To Reproduce
Expected behavior
Creating a file with Append mode should consistently work on all supported platforms.
This is useful e.g. for simulation codes, e.g. setting Append mode by default, so that restarting from a checkpoint will not delete previous data, but append to the data.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
Following up
Was the issue fixed? Please report back.
The text was updated successfully, but these errors were encountered: